chore: Correct l10n service usage (#5354)

Author: iamareebjamal

app/components/account/application-section.js

@@ -41,7 +41,7 @@ export default class ApplicationSection extends Component {
         });
       }
     } catch (error) {
-      this.notify.error(this.l10n.t(error.message), {
+      this.notify.error(error.message, {
         id: 'error_message'
       });
       this.set('isLoading', false);

app/components/events/view/export/download-zip.js

@@ -19,7 +19,7 @@ export default class DownloadZip extends Component {
       });
     } catch (e) {
       console.error('Error while downloading event zip', e);
-      this.notify.error(this.l10n.t(e), {
+      this.notify.error(e, {
         id: 'err_down'
       });
     }

app/components/forms/admin/settings/system-form.js

@@ -152,7 +152,7 @@ export default Component.extend(FormMixin, {
             },
             {
               type   : 'email',
-              prompt : this.l10n.t('Please enter a valid  email address')
+              prompt : this.l10n.t('Please enter a valid email address')
             }
           ]
         },

app/components/forms/orders/order-form.js

@@ -418,7 +418,7 @@ export default Component.extend(FormMixin, {
           rules      : [
             {
               type   : 'empty',
-              prompt : this.l10n.t('Please enter your city ')
+              prompt : this.l10n.t('Please enter your city')
             }
           ]
         },
@@ -476,7 +476,7 @@ export default Component.extend(FormMixin, {
           rules: [
             {
               type   : 'empty',
-              prompt : this.l10n.t('Please enter ' + field.name)
+              prompt : 'Please enter ' + field.name
             }
           ]
         };

app/components/forms/session-speaker-form.js

@@ -387,7 +387,7 @@ export default Component.extend(FormMixin, {
           rules: [
             {
               type   : 'empty',
-              prompt : this.l10n.t('Please enter ' + field.name)
+              prompt : 'Please enter ' + field.name
             }
           ]
         };

app/components/forms/wizard/basic-details-step.js

@@ -431,7 +431,7 @@ export default Component.extend(FormMixin, EventWizardMixin, {
         })
         .catch(error => {
           console.error('Error while setting stripe authorization in event', error);
-          this.notify.error(this.l10n.t(`${error.message}. Please try again`), {
+          this.notify.error(error.message + '. ' + this.l10n.t('Please try again'), {
             id: 'basic_detail_err'
           });
         });

app/components/forms/wizard/custom-form-input.hbs

@@ -17,5 +17,5 @@
       <div class="item" data-value="number">Number</div>
     </div>
   </UiDropdown>
-  <button class="ui button" {{action 'addFormField'}} disabled={{not this.validIdentifier}}>{{t (if @field 'Save' 'Add')}}</button>
+  <button class="ui button" {{action 'addFormField'}} disabled={{not this.validIdentifier}}>{{if @field (t 'Save') (t 'Add')}}</button>
 </div>

app/components/forms/wizard/custom-forms/table.hbs

@@ -3,7 +3,7 @@
     {{#if @headerText}}
       <tr>
         <th colspan="{{if this.editColumn '5' '4'}}" class="text center aligned">
-          {{t @headerText}}
+          {{@headerText}}
         </th>
       </tr>
     {{/if}}

app/components/public/ticket-list.js

@@ -223,7 +223,10 @@ export default Component.extend(FormMixin, {
         rules      : [
           {
             type   : `integer[${donationTicket.minPrice}..${donationTicket.maxPrice}]`,
-            prompt : this.l10n.t(`Please enter a donation amount between ${donationTicket.minPrice} and ${donationTicket.maxPrice}`)
+            prompt : this.l10n.t('Please enter a donation amount between {{minPrice}} and {{maxPrice}}', {
+              minPrice : donationTicket.minPrice,
+              maxPrice : donationTicket.maxPrice
+            })
           }
         ]
       };

app/components/unverified-user-message.js

@@ -30,7 +30,7 @@ export default class UnverifiedUserMessage extends Component {
       .catch(error => {
         console.error('Error while sending verification email', error, error.error);
         if (error.error) {
-          this.notify.error(this.l10n.t(error.error), {
+          this.notify.error(error.error, {
             id: 'ver_mail_serv_error'
           });
         } else {