Skip to content

Commit 2315c39

Browse files
author
DIVYAM TAYAL
authored
chore: Change general-date helper timezone argument (#5799)
* Making tz Argument * Making tz Argument-1
1 parent d427ea6 commit 2315c39

33 files changed

+57
-57
lines changed

app/components/public/add-to-calender.hbs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,9 +3,9 @@
33
<i class="clock alternate outline icon pt-1"></i>
44
<div class="content">
55
{{#if this.isSingleDay}}
6-
{{general-date @event.startsAt @event.timezone "dddd, D MMMM, YYYY"}}<br>{{general-date @event.startsAt @event.timezone "h:mm A"}} {{t 'to'}} {{general-date @event.endsAt @event.timezone "h:mm A"}}
6+
{{general-date @event.startsAt "dddd, D MMMM, YYYY" tz=@event.timezone}}<br>{{general-date @event.startsAt "h:mm A" tz=@event.timezone}} {{t 'to'}} {{general-date @event.endsAt "h:mm A" tz=@event.timezone}}
77
{{else}}
8-
{{general-date @event.startsAt @event.timezone "dddd, D MMMM, YYYY h:mm A"}} {{t 'to'}} {{general-date @event.endsAt @event.timezone "dddd, D MMMM, YYYY h:mm A"}}
8+
{{general-date @event.startsAt "dddd, D MMMM, YYYY h:mm A" tz=@event.timezone}} {{t 'to'}} {{general-date @event.endsAt "dddd, D MMMM, YYYY h:mm A" tz=@event.timezone}}
99
{{/if}}
1010
({{this.timezone}})
1111
<br>

app/components/public/session-item.hbs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@
2727
<div class="left floated twelve wide column">
2828
{{#if @session.startsAt}}
2929
<div class=""><i class="icon map marker alternate"></i>{{@session.microlocation.name}}</div>
30-
<div class="small text"><i class="wait icon"></i>{{general-date @session.startsAt @timezone}} - {{general-date @session.endsAt @timezone}}</div>
30+
<div class="small text"><i class="wait icon"></i>{{general-date @session.startsAt tz=@timezone}} - {{general-date @session.endsAt tz=@timezone}}</div>
3131
{{/if}}
3232
</div>
3333
{{else}}
@@ -49,7 +49,7 @@
4949
<div class="right floated four wide column">
5050
{{#if @session.startsAt}}
5151
<div class=""><i class="icon map marker alternate"></i>{{@session.microlocation.name}}</div>
52-
<div class="small text"><i class="wait icon"></i>{{general-date @session.startsAt @timezone 'D MMM, YYYY h:mm A (z)'}}</div>
52+
<div class="small text"><i class="wait icon"></i>{{general-date @session.startsAt 'D MMM, YYYY h:mm A (z)' tz=@timezone}}</div>
5353
{{/if}}
5454
</div>
5555
{{/if}}
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
{{general-date @record @props.options.timezone @props.options.dateFormat}}
1+
{{general-date @record @props.options.dateFormat tz=@props.options.timezone}}

app/helpers/general-date.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3,12 +3,12 @@ import moment from 'moment';
33

44
const locales12Hours = new Set(['en', 'bn', 'hi', 'id', 'ja', 'run', 'th', 'vi', 'ko']);
55

6-
export function generalDate(params) {
7-
const timezone = params[1] || moment.tz.guess();
6+
export function generalDate(params, { tz }) {
7+
const timezone = tz || moment.tz.guess();
88

99
const local = moment(params[0]).tz(timezone).locale();
1010

11-
let format = params[2] || 'h:mm A, MMMM Do YYYY (z)';
11+
let format = params[1] || 'h:mm A, MMMM Do YYYY (z)';
1212

1313
if (!locales12Hours.has(local)) {
1414
format = format.replaceAll('h', 'H');

app/templates/admin/sales/revenue.hbs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@
3838
{{order.name}}
3939
</td>
4040
<td>
41-
{{general-date order.eventDate '' 'D MMM, YYYY'}}
41+
{{general-date order.eventDate 'D MMM, YYYY'}}
4242
</td>
4343
<td class="right aligned">
4444
{{order.ticketCount}}

app/templates/components/event-card.hbs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@
2323
</SmartOverflow>
2424
<div class="meta">
2525
<span class="date">
26-
{{general-date this.event.startsAt this.event.timezone}}
26+
{{general-date this.event.startsAt tz=this.event.timezone}}
2727
</span>
2828
</div>
2929
<SmartOverflow @class="description">

app/templates/components/event-invoice/event-info.hbs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,9 +12,9 @@
1212
<div class="ui padded segment">
1313
<strong>{{t 'At'}} {{this.event.locationName}}</strong>
1414
<br>
15-
<strong>{{t 'From'}}:</strong> {{general-date this.event.startsAt '' 'dddd, D MMMM, YYYY h:mm A'}}
15+
<strong>{{t 'From'}}:</strong> {{general-date this.event.startsAt 'dddd, D MMMM, YYYY h:mm A'}}
1616
<br>
17-
<strong>{{t 'To'}}:</strong> {{general-date this.event.endsAt '' 'dddd, D MMMM, YYYY h:mm A'}}
17+
<strong>{{t 'To'}}:</strong> {{general-date this.event.endsAt 'dddd, D MMMM, YYYY h:mm A'}}
1818
{{#if this.event.ownerName}}
1919
<br>
2020
<strong>{{t 'Organized By'}}:</strong> {{this.event.ownerName}}

app/templates/components/event-invoice/invoice-summary.hbs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -26,8 +26,8 @@
2626
<tbody>
2727
<tr>
2828
<td>{{this.event.name}}</td>
29-
<td>{{general-date this.data.issuedAt '' 'D MMM, YYYY'}}</td>
30-
<td>{{general-date this.data.completedAt '' 'D MMM, YYYY'}}</td>
29+
<td>{{general-date this.data.issuedAt 'D MMM, YYYY'}}</td>
30+
<td>{{general-date this.data.completedAt 'D MMM, YYYY'}}</td>
3131
<td>{{currency-symbol this.eventCurrency}} {{format-money this.data.amount}}</td>
3232
</tr>
3333
</tbody>

app/templates/components/events/view/overview/general-info.hbs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -25,11 +25,11 @@
2525
</tr>
2626
<tr>
2727
<td><strong>{{t 'Start time'}}</strong></td>
28-
<td>{{general-date this.data.event.startsAt this.data.event.timezone}}</td>
28+
<td>{{general-date this.data.event.startsAt tz=this.data.event.timezone}}</td>
2929
</tr>
3030
<tr>
3131
<td><strong>{{t 'End time'}}</strong></td>
32-
<td>{{general-date this.data.event.endsAt this.data.event.timezone}}</td>
32+
<td>{{general-date this.data.event.endsAt tz=this.data.event.timezone}}</td>
3333
</tr>
3434
<tr>
3535
<td><strong>{{t 'Session types'}}</strong></td>

app/templates/components/footer-main.hbs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -105,7 +105,7 @@
105105
<div class="ui stackable grid">
106106
<div class="thirteen wide computer twelve wide tablet column left aligned">
107107
<div class="ui horizontal inverted small divided link list no top margin">
108-
<span class="item">{{t 'Copyright'}} &copy; {{general-date (now) '' 'YYYY'}} {{this.settings.appName}} </span>
108+
<span class="item">{{t 'Copyright'}} &copy; {{general-date (now) 'YYYY'}} {{this.settings.appName}} </span>
109109
<span class="hidden-item">
110110
{{!-- Possible Page Values --}}
111111
{{t 'Terms'}}

0 commit comments

Comments
 (0)