Skip to content

Commit af8490d

Browse files
committed
no-settled-after-test-helper: Add missing node type check in isAwaitSettlingTestHelper()
1 parent e7b8db6 commit af8490d

File tree

2 files changed

+15
-0
lines changed

2 files changed

+15
-0
lines changed

lib/rules/no-settled-after-test-helper.js

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -111,6 +111,10 @@ function isAwaitSettled(node) {
111111
}
112112

113113
function isAwaitSettlingTestHelper(node, settlingTestHelpers) {
114+
if (node.type !== 'ExpressionStatement') {
115+
return false;
116+
}
117+
114118
const { expression } = node;
115119
if (expression.type !== 'AwaitExpression') {
116120
return false;

tests/lib/rules/no-settled-after-test-helper.js

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -63,6 +63,17 @@ ruleTester.run('no-settled-after-test-helper', rule, {
6363
await settled();
6464
}
6565
`,
66+
`
67+
import { settled } from '@ember/test-helpers';
68+
69+
export async function visit(url) {
70+
try {
71+
something();
72+
} catch {}
73+
74+
await settled();
75+
}
76+
`,
6677
],
6778
invalid: [
6879
{

0 commit comments

Comments
 (0)