fix: ESS stack clean up steps (#9832)

* fix: specify terraform env var everywhere

* fix: proper env vars for ESS Stack clean up

* fix: error when terraform fails to destroy ESS stack

* fix: pass ess_region in terraform destroy

Author: pkoutsovasilis

.buildkite/bk.integration-fips.pipeline.yml

@@ -7,6 +7,7 @@ env:
   IMAGE_UBUNTU_2404_X86_64: "platform-ingest-elastic-agent-ubuntu-2404-1757120457"
   IMAGE_UBUNTU_X86_64_FIPS: "platform-ingest-elastic-agent-ubuntu-2204-fips-1757120457"
   IMAGE_UBUNTU_ARM64_FIPS: "platform-ingest-elastic-agent-ubuntu-2204-fips-aarch64-1757120457"
+  ASDF_TERRAFORM_VERSION: 1.9.2
 
 # This section is used to define the plugins that will be used in the pipeline.
 # See https://buildkite.com/docs/pipelines/integrations/plugins/using#using-yaml-anchors-with-plugins
@@ -21,7 +22,6 @@ steps:
   - label: Start ESS stack for FIPS integration tests
     key: integration-fips-ess
     env:
-      ASDF_TERRAFORM_VERSION: 1.9.2
       FIPS: "true"
       EC_ENDPOINT: "https://api.staging.elastic-gov.com"
       ESS_REGION: "us-gov-east-1"
@@ -127,6 +127,13 @@ steps:
   - label: ESS FIPS stack cleanup
     depends_on:
       - integration-tests-ubuntu-fips
+    env:
+      FIPS: "true"
+      EC_ENDPOINT: "https://api.staging.elastic-gov.com"
+      ESS_REGION: "us-gov-east-1"
+      TF_VAR_deployment_template_id: "aws-general-purpose"
+      TF_VAR_integration_server_docker_image: "docker.elastic.co/beats-ci/elastic-agent-cloud-fips:git-${BUILDKITE_COMMIT:0:12}"
+      TF_VAR_docker_images_name_suffix: "-fips"
     allow_dependency_failure: true
     command: |
       buildkite-agent artifact download "test_infra/ess/**" . --step "integration-fips-ess"

.buildkite/bk.integration.pipeline.yml

@@ -12,6 +12,7 @@ env:
   IMAGE_DEBIAN_12: "platform-ingest-elastic-agent-debian-12-1757120457"
   IMAGE_WIN_2022: "platform-ingest-elastic-agent-windows-2022-1757120457"
   IMAGE_WIN_2025: "platform-ingest-elastic-agent-windows-2025-1757120457"
+  ASDF_TERRAFORM_VERSION: 1.9.2
 
 # This section is used to define the plugins that will be used in the pipeline.
 # See https://buildkite.com/docs/pipelines/integrations/plugins/using#using-yaml-anchors-with-plugins
@@ -74,8 +75,6 @@ steps:
     notify:
       - github_commit_status:
           context: "buildkite/elastic-agent-extended-testing - ESS stack provision"
-    env:
-      ASDF_TERRAFORM_VERSION: 1.9.2
     command: .buildkite/scripts/steps/ess_start.sh
     retry:
       automatic:

.buildkite/scripts/steps/ess.ps1

@@ -40,6 +40,9 @@ function ess_up {
 }
 
 function ess_down {
+  param (
+      [string]$EssRegion = "gcp-us-west2"
+  )
   $Workspace = & git rev-parse --show-toplevel
   $TfDir = Join-Path -Path $Workspace -ChildPath "test_infra/ess/"
   $stateFilePath = Join-Path -Path $TfDir -ChildPath "terraform.tfstate"
@@ -52,7 +55,8 @@ function ess_down {
   try {
     Push-Location -Path $TfDir
     & terraform init
-    & terraform destroy -auto-approve
+    & terraform destroy -auto-approve `
+      -var="ess_region=$EssRegion"
     Pop-Location
   } catch {
     Write-Output "Error: Failed to destroy ESS stack(it will be auto-deleted later): $_"

.buildkite/scripts/steps/ess.sh

@@ -40,13 +40,15 @@ function ess_up() {
 }
 
 function ess_down() {
-  echo "~~~ Tearing down the ESS Stack"  
+  echo "~~~ Tearing down the ESS Stack"
+  local ESS_REGION=${1:-"gcp-us-west2"}
   local WORKSPACE=$(git rev-parse --show-toplevel)
   local TF_DIR="${WORKSPACE}/test_infra/ess/"
 
   pushd "${TF_DIR}"
   terraform init
-  terraform destroy -auto-approve
+  terraform destroy -auto-approve \
+    -var="ess_region=${ESS_REGION}"
   popd
 }
 

.buildkite/scripts/steps/ess_down.sh

@@ -3,4 +3,6 @@ set -euo pipefail
 
 source .buildkite/scripts/steps/ess.sh
 
-ess_down || echo "Failed to stop ESS stack" >&2
+ESS_REGION="${ESS_REGION:-gcp-us-west2}"
+
+ess_down "$ESS_REGION"