Skip to content

Commit 78e8631

Browse files
fix: replace AssertJ's deprecated asList() DSL method in PodTemplateHandlerTest (3465)
Replaced asList() method with asInstanceOf(InstanceOfAssertFactories.list(Type.class) --- Replaced asList() method with asInstanceOf(InstanceOfAssertFactories.list(Type.class) --- repushing the code dueto some failuers
1 parent beb975c commit 78e8631

File tree

1 file changed

+9
-6
lines changed

1 file changed

+9
-6
lines changed

jkube-kit/enricher/api/src/test/java/org/eclipse/jkube/kit/enricher/handler/PodTemplateHandlerTest.java

Lines changed: 9 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,8 @@
1616
import io.fabric8.kubernetes.api.model.LocalObjectReference;
1717
import io.fabric8.kubernetes.api.model.PodSpec;
1818
import io.fabric8.kubernetes.api.model.PodTemplateSpec;
19+
import io.fabric8.kubernetes.api.model.Volume;
20+
import io.fabric8.kubernetes.api.model.Container;
1921
import org.assertj.core.api.InstanceOfAssertFactories;
2022
import org.eclipse.jkube.kit.config.image.build.BuildConfiguration;
2123
import org.eclipse.jkube.kit.config.image.ImageConfiguration;
@@ -87,7 +89,7 @@ void getPodTemplate_withoutVolumeConfig_shouldGeneratePodTemplateWithoutVolume()
8789
assertThat(podTemplateSpec.getSpec().getVolumes()).isEmpty();
8890
assertThat(podTemplateSpec.getSpec())
8991
.extracting(PodSpec::getContainers).isNotNull()
90-
.asList()
92+
.asInstanceOf(InstanceOfAssertFactories.list(Container.class))
9193
.first()
9294
.hasFieldOrPropertyWithValue("name", "test-app")
9395
.hasFieldOrPropertyWithValue("image", "docker.io/test:latest")
@@ -105,10 +107,10 @@ void getPodTemplate_withEmptyVolumeAndWithoutServiceAccount_shouldGeneratePodTem
105107

106108
PodTemplateSpec podTemplateSpec = podTemplateHandler.getPodTemplate(config, null, images);
107109
assertThat(podTemplateSpec.getSpec())
108-
.hasFieldOrPropertyWithValue("serviceAccountName", null)
109-
.returns(true, spec -> spec.getVolumes().isEmpty())
110-
.extracting(PodSpec::getContainers)
111-
.isNotNull();
110+
.hasFieldOrPropertyWithValue("serviceAccountName", null)
111+
.returns(true, spec -> spec.getVolumes().isEmpty())
112+
.extracting(PodSpec::getContainers)
113+
.isNotNull();
112114
}
113115

114116
@Test
@@ -128,7 +130,8 @@ void getPodTemplate_withVolumeAndServiceAccount_shouldGeneratePodTemplateWithCon
128130

129131
assertThat(podTemplateSpec.getSpec().getContainers()).isNotNull();
130132
assertThat(podTemplateSpec.getSpec())
131-
.extracting(PodSpec::getVolumes).asList()
133+
.extracting(PodSpec::getVolumes)
134+
.asInstanceOf(InstanceOfAssertFactories.list(Volume.class))
132135
.isNotEmpty()
133136
.first()
134137
.hasFieldOrPropertyWithValue("name", "test")

0 commit comments

Comments
 (0)