Skip to content

Commit 3f277e4

Browse files
Couple of fixes for MEAI.Evaluation (#6673)
* Truncate long metric values in trends table * Simplify metadata for ContentSafetyChatClient
1 parent 11e16a9 commit 3f277e4

File tree

2 files changed

+15
-33
lines changed

2 files changed

+15
-33
lines changed

src/Libraries/Microsoft.Extensions.AI.Evaluation.Reporting/TypeScript/components/MetricCard.tsx

Lines changed: 9 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -242,9 +242,14 @@ export const MetricDisplay = ({ metric }: { metric: MetricWithNoValue | NumericM
242242
const classes = useCardStyles();
243243
const { fg, bg } = useCardColors(metric.interpretation);
244244

245-
const pillClass = mergeClasses(
246-
bg,
247-
classes.metricPill,
245+
const pillClass = mergeClasses(bg, classes.metricPill);
246+
const valueClass = mergeClasses(fg, classes.metricValueText);
247+
248+
return (
249+
<Tooltip content={`${metric.name}: ${metricValue}`} relationship="description">
250+
<div className={pillClass}>
251+
<span className={valueClass}>{metricValue}</span>
252+
</div>
253+
</Tooltip>
248254
);
249-
return (<div className={pillClass}><span className={fg}>{metricValue}</span></div>);
250255
};

src/Libraries/Microsoft.Extensions.AI.Evaluation.Safety/ContentSafetyChatClient.cs

Lines changed: 6 additions & 29 deletions
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,8 @@ namespace Microsoft.Extensions.AI.Evaluation.Safety;
2020

2121
internal sealed class ContentSafetyChatClient : IChatClient
2222
{
23-
private const string Moniker = "Azure AI Foundry Evaluation";
23+
private const string ProviderName = "azure.ai.foundry";
24+
private const string ModelId = $"{ProviderName}.evaluation";
2425

2526
private readonly ContentSafetyService _service;
2627
private readonly IChatClient? _originalChatClient;
@@ -35,38 +36,14 @@ public ContentSafetyChatClient(
3536

3637
ChatClientMetadata? originalMetadata = _originalChatClient?.GetService<ChatClientMetadata>();
3738

38-
string providerName;
39-
Uri? providerUri = originalMetadata?.ProviderUri;
40-
41-
if (contentSafetyServiceConfiguration.IsHubBasedProject)
42-
{
43-
providerName =
44-
$"{Moniker} (" +
45-
$"Subscription: {contentSafetyServiceConfiguration.SubscriptionId}, " +
46-
$"Resource Group: {contentSafetyServiceConfiguration.ResourceGroupName}, " +
47-
$"Project: {contentSafetyServiceConfiguration.ProjectName})";
48-
}
49-
else
50-
{
51-
providerName = $"{Moniker} (Endpoint: {contentSafetyServiceConfiguration.Endpoint})";
52-
providerUri = contentSafetyServiceConfiguration.Endpoint;
53-
}
54-
39+
string providerName = ProviderName;
5540
if (originalMetadata?.ProviderName is string originalProviderName &&
5641
!string.IsNullOrWhiteSpace(originalProviderName))
5742
{
5843
providerName = $"{providerName}; {originalProviderName}";
5944
}
6045

61-
string modelId = Moniker;
62-
63-
if (originalMetadata?.DefaultModelId is string originalModelId &&
64-
!string.IsNullOrWhiteSpace(originalModelId))
65-
{
66-
modelId = $"{modelId}; {originalModelId}";
67-
}
68-
69-
_metadata = new ChatClientMetadata(providerName, providerUri, modelId);
46+
_metadata = new ChatClientMetadata(providerName, defaultModelId: ModelId);
7047
}
7148

7249
public async Task<ChatResponse> GetResponseAsync(
@@ -88,7 +65,7 @@ await _service.AnnotateAsync(
8865

8966
return new ChatResponse(new ChatMessage(ChatRole.Assistant, annotationResult))
9067
{
91-
ModelId = Moniker
68+
ModelId = ModelId
9269
};
9370
}
9471
else
@@ -121,7 +98,7 @@ await _service.AnnotateAsync(
12198

12299
yield return new ChatResponseUpdate(ChatRole.Assistant, annotationResult)
123100
{
124-
ModelId = Moniker
101+
ModelId = ModelId
125102
};
126103
}
127104
else

0 commit comments

Comments
 (0)