Don't use File.OpenWrite when trying to overwrite a file (#15930)

File.OpenWrite will open an existing file which means if you write data that is shorter than the existing data the file will be corrupt. This is documented on https://learn.microsoft.com/en-us/dotnet/api/system.io.file.openwrite

> The OpenWrite method opens a file if one already exists for the file path, or creates a new file if one does not exist. For an existing file, it does not append the new text to the existing text. Instead, it overwrites the existing characters with the new characters. If you overwrite a longer string (such as "This is a test of the OpenWrite method") with a shorter string (such as "Second run"), the file will contain a mix of the strings ("Second runtest of the OpenWrite method").

The fix is to use  `File.Create` instead in cases where the intention is to create a new file or overwrite an existing one.

Author: akoeplinger

src/Microsoft.DotNet.Build.Tasks.Installers/src/CreateChangelogFile.cs

@@ -37,7 +37,7 @@ public sealed class CreateChangelogFile : BuildTask
 
         public override bool Execute()
         {
-            using GZipStream stream = new(File.OpenWrite(ChangelogOutputPath), CompressionLevel.Optimal);
+            using GZipStream stream = new(File.Create(ChangelogOutputPath), CompressionLevel.Optimal);
             using StreamWriter writer = new(stream, Encoding.ASCII);
             writer.WriteLine($"{PackageName} ({PackageVersion}) unstable; urgency=low");
             writer.WriteLine();

src/Microsoft.DotNet.Build.Tasks.Installers/src/CreateControlFile.cs

@@ -42,7 +42,7 @@ public sealed class CreateControlFile : BuildTask
 
         public override bool Execute()
         {
-            using Stream stream = File.OpenWrite(ControlFileOutputPath);
+            using Stream stream = File.Create(ControlFileOutputPath);
             using StreamWriter writer = new(stream, Encoding.ASCII);
             writer.WriteLine($"Package: {PackageName}");
             writer.WriteLine($"Version: {PackageVersion}");

src/Microsoft.DotNet.Build.Tasks.Installers/src/CreateMD5SumsFile.cs

@@ -29,7 +29,7 @@ public sealed class CreateMD5SumsFile : BuildTask
 
         public override bool Execute()
         {
-            using FileStream outputFile = File.OpenWrite(OutputFile);
+            using FileStream outputFile = File.Create(OutputFile);
             using StreamWriter writer = new(outputFile, Encoding.ASCII);
             ulong installedSize = 0;
             foreach (ITaskItem file in Files)

src/Microsoft.DotNet.Build.Tasks.Installers/src/GenerateMacOSDistributionFile.cs

@@ -117,7 +117,7 @@ public override bool Execute()
                 document.Root.Add(choiceElements);
                 document.Root.Add(pkgRefElements);
                 document.Root.Add(scriptElement);
-                using XmlWriter writer = XmlWriter.Create(File.OpenWrite(DestinationFile));
+                using XmlWriter writer = XmlWriter.Create(File.Create(DestinationFile));
                 document.WriteTo(writer);
             }
             catch (Exception ex)

src/SignCheck/Microsoft.SignCheck/Verification/RpmVerifier.cs

@@ -24,7 +24,7 @@ protected override IEnumerable<ArchiveEntry> ReadArchiveEntries(string archivePa
 
             using var stream = File.Open(archivePath, FileMode.Open);
             using RpmPackage rpmPackage = RpmPackage.Read(stream);
-            using var dataStream = File.OpenWrite(Path.Combine(Path.GetTempPath(), Guid.NewGuid().ToString()));
+            using var dataStream = File.Create(Path.Combine(Path.GetTempPath(), Guid.NewGuid().ToString()));
             using var archive = new CpioReader(rpmPackage.ArchiveStream, leaveOpen: false);
 
             while (archive.GetNextEntry() is CpioEntry entry)