Fix Jaeger status

Based on the changes of open-telemetry#358

Signed-off-by: Daniel González Lopes <[email protected]>

Author: dgzlopes

ext/opentelemetry-ext-jaeger/src/opentelemetry/ext/jaeger/__init__.py

@@ -156,20 +156,19 @@ def _translate_to_jaeger(spans: Span):
 
         tags = _extract_tags(span.attributes)
 
-        if status is not None:
-            if tags is None:
-                tags = []
-
-            tags.extend(
-                [
-                    _get_long_tag("status.code", status.canonical_code.value),
-                    _get_string_tag("status.message", status.description),
-                ]
-            )
+        if tags is None:
+            tags = []
+
+        tags.extend(
+            [
+                _get_long_tag("status.code", status.canonical_code.value),
+                _get_string_tag("status.message", status.description),
+            ]
+        )
 
-            # Ensure that if Status.Code is not OK, that we set the "error" tag on the Jaeger span.
-            if status.canonical_code is not StatusCanonicalCode.OK:
-                tags.append(_get_bool_tag("error", True))
+        # Ensure that if Status.Code is not OK, that we set the "error" tag on the Jaeger span.
+        if status.canonical_code is not StatusCanonicalCode.OK:
+            tags.append(_get_bool_tag("error", True))
 
         refs = _extract_refs_from_span(span)
         logs = _extract_logs_from_span(span)

ext/opentelemetry-ext-jaeger/tests/test_jaeger_exporter.py

@@ -156,6 +156,13 @@ def test_translate_to_jaeger(self):
             context=other_context, attributes=link_attributes
         )
 
+        default_status_tags = [
+            jaeger.Tag(key="status.code", vType=jaeger.TagType.LONG, vLong=0,),
+            jaeger.Tag(
+                key="status.message", vType=jaeger.TagType.STRING, vStr=None,
+            ),
+        ]
+
         otel_spans = [
             trace.Span(
                 name=span_names[0],
@@ -176,7 +183,7 @@ def test_translate_to_jaeger(self):
         otel_spans[0].set_attribute("key_string", "hello_world")
         otel_spans[0].set_attribute("key_float", 111.22)
         otel_spans[0].set_status(
-            Status(StatusCanonicalCode.OK, "Example description")
+            Status(StatusCanonicalCode.UNKNOWN, "Example description")
         )
         otel_spans[0].end(end_time=end_times[0])
 
@@ -214,13 +221,16 @@ def test_translate_to_jaeger(self):
                         vDouble=111.22,
                     ),
                     jaeger.Tag(
-                        key="status.code", vType=jaeger.TagType.LONG, vLong=0,
+                        key="status.code", vType=jaeger.TagType.LONG, vLong=2,
                     ),
                     jaeger.Tag(
                         key="status.message",
                         vType=jaeger.TagType.STRING,
                         vStr="Example description",
                     ),
+                    jaeger.Tag(
+                        key="error", vType=jaeger.TagType.BOOL, vBool=True,
+                    ),
                 ],
                 references=[
                     jaeger.SpanRef(
@@ -267,6 +277,7 @@ def test_translate_to_jaeger(self):
                 startTime=start_times[1] // 10 ** 3,
                 duration=durations[1] // 10 ** 3,
                 flags=0,
+                tags=default_status_tags,
             ),
             jaeger.Span(
                 operationName=span_names[2],
@@ -277,6 +288,7 @@ def test_translate_to_jaeger(self):
                 startTime=start_times[2] // 10 ** 3,
                 duration=durations[2] // 10 ** 3,
                 flags=0,
+                tags=default_status_tags,
             ),
         ]