fix: pre-check for get permissions only on port-forward (#3322)

y-rabie · web-flow · commit b68b68e23fbf · 2025-05-08T06:51:22.000-06:00
diff --git a/internal/dao/port_forwarder.go b/internal/dao/port_forwarder.go
@@ -141,7 +141,7 @@ func (p *PortForwarder) Start(path string, tt port.PortTunnel) (*portforward.Por
 		return nil, fmt.Errorf("unable to forward port because pod is not running. Current status=%v", pod.Status.Phase)
 	}
 
-	auth, err = p.Client().CanI(ns, client.PodGVR.WithSubResource("portforward"), "", []string{client.CreateVerb})
+	auth, err = p.Client().CanI(ns, client.PodGVR.WithSubResource("portforward"), "", []string{client.GetVerb})
 	if err != nil {
 		return nil, err
 	}

Original file line number	Diff line number	Diff line change
`@@ -141,7 +141,7 @@ func (p PortForwarder) Start(path string, tt port.PortTunnel) (portforward.Por`
`141`	`141`	`return nil, fmt.Errorf("unable to forward port because pod is not running. Current status=%v", pod.Status.Phase)`
`142`	`142`	`}`
`143`	`143`
`144`		`- auth, err = p.Client().CanI(ns, client.PodGVR.WithSubResource("portforward"), "", []string{client.CreateVerb})`
	`144`	`+ auth, err = p.Client().CanI(ns, client.PodGVR.WithSubResource("portforward"), "", []string{client.GetVerb})`
`145`	`145`	`if err != nil {`
`146`	`146`	`return nil, err`
`147`	`147`	`}`