Address issue #684

* `vacuum lint example.yaml` - will fetch remotes ✅
* `vacuum lint example.yaml --remote` - will also fetch remotes ✅
* `vacuum lint example.yaml --remote=false` - will not fetch remotes ✅
* `vacuum report example.yaml` - will fetch remotes ✅
* `vacuum report example.yaml --remote` - will also fetch remotes ✅
* `vacuum report example.yaml --remote=false` - will not fetch remotes ✅
* `vacuum html-report example.yaml` - will fetch remotes ✅
* `vacuum html-report example.yaml --remote` - will also fetch remotes ✅
* `vacuum html-report example.yaml --remote=false` - will not fetch remotes ✅
* `vacuum spectral-report example.yaml` - will fetch remotes ✅
* `vacuum spectral-report example.yaml --remote` - will also fetch remotes ✅
* `vacuum spectral-report example.yaml --remote=false` - will not fetch remotes ✅
* `vacuum bundle example.yaml` - will fetch remotes ✅
* `vacuum bundle example.yaml --remote` - will also fetch remotes ✅
* `vacuum bundle example.yaml --remote=false` - will not fetch remotes ✅
* `vacuum dashboard example.yaml` - will fetch remotes ✅
* `vacuum dashboard example.yaml --remote` - will also fetch remotes ✅
* `vacuum dashboard example.yaml --remote=false` - will not fetch remotes ✅
* `vacuum spectral-report example.yaml` - will fetch remotes ✅
* `vacuum spectral=report example.yaml --remote` - will also fetch remotes ✅
* `vacuum spectral-report example.yaml --remote=false` - will not fetch remotes ✅

Author: daveshanley

cmd/build_results.go

@@ -16,8 +16,9 @@ func BuildResults(
 	specBytes []byte,
 	customFunctions map[string]model.RuleFunction,
 	base string,
+	remote bool,
 	timeout time.Duration) (*model.RuleResultSet, *motor.RuleSetExecutionResult, error) {
-	return BuildResultsWithDocCheckSkip(silent, hardMode, rulesetFlag, specBytes, customFunctions, base, false, timeout)
+	return BuildResultsWithDocCheckSkip(silent, hardMode, rulesetFlag, specBytes, customFunctions, base, remote, false, timeout)
 }
 
 func BuildResultsWithDocCheckSkip(
@@ -27,6 +28,7 @@ func BuildResultsWithDocCheckSkip(
 	specBytes []byte,
 	customFunctions map[string]model.RuleFunction,
 	base string,
+	remote bool,
 	skipCheck bool,
 	timeout time.Duration) (*model.RuleResultSet, *motor.RuleSetExecutionResult, error) {
 
@@ -76,7 +78,7 @@ func BuildResultsWithDocCheckSkip(
 		CustomFunctions:   customFunctions,
 		Base:              base,
 		SkipDocumentCheck: skipCheck,
-		AllowLookup:       true,
+		AllowLookup:       remote,
 		Timeout:           timeout,
 	})
 

cmd/build_results_test.go

@@ -6,11 +6,11 @@ import (
 )
 
 func TestBuildResults(t *testing.T) {
-	_, _, err := BuildResults(false, false, "nuggets", nil, nil, "", 5)
+	_, _, err := BuildResults(false, false, "nuggets", nil, nil, "", true, 5)
 	assert.Error(t, err)
 }
 
 func TestBuildResults_SkipCheck(t *testing.T) {
-	_, _, err := BuildResultsWithDocCheckSkip(false, false, "nuggets", nil, nil, "", true, 5)
+	_, _, err := BuildResultsWithDocCheckSkip(false, false, "nuggets", nil, nil, "", true, true, 5)
 	assert.Error(t, err)
 }

cmd/dashboard.go

@@ -46,6 +46,7 @@ func GetDashboardCommand() *cobra.Command {
 			hardModeFlag, _ := cmd.Flags().GetBool("hard-mode")
 			silent, _ := cmd.Flags().GetBool("silent")
 			extensionRefsFlag, _ := cmd.Flags().GetBool("ext-refs")
+			remoteFlag, _ := cmd.Flags().GetBool("remote")
 
 			var err error
 			vacuumReport, specBytes, _ := vacuum_report.BuildVacuumReportFromFile(args[0])
@@ -67,7 +68,7 @@ func GetDashboardCommand() *cobra.Command {
 
 				rulesetFlag, _ := cmd.Flags().GetString("ruleset")
 				resultSet, ruleset, err = BuildResultsWithDocCheckSkip(false, hardModeFlag, rulesetFlag, specBytes, customFunctions,
-					baseFlag, skipCheckFlag, time.Duration(timeoutFlag)*time.Second)
+					baseFlag, remoteFlag, skipCheckFlag, time.Duration(timeoutFlag)*time.Second)
 				if err != nil {
 					pterm.Error.Printf("Failed to render dashboard: %v\n\n", err)
 					return err
@@ -100,7 +101,7 @@ func GetDashboardCommand() *cobra.Command {
 						config.BasePath = baseFlag
 					}
 					config.AllowFileLookup = true
-					config.AllowRemoteLookup = true
+					config.AllowRemoteLookup = remoteFlag
 				}
 
 				if extensionRefsFlag {

cmd/html_report.go

@@ -47,6 +47,7 @@ func GetHTMLReportCommand() *cobra.Command {
 			timeoutFlag, _ := cmd.Flags().GetInt("timeout")
 			hardModeFlag, _ := cmd.Flags().GetBool("hard-mode")
 			silent, _ := cmd.Flags().GetBool("silent")
+			remoteFlag, _ := cmd.Flags().GetBool("remote")
 
 			// disable color and styling, for CI/CD use.
 			// https://github.com/daveshanley/vacuum/issues/234
@@ -96,7 +97,7 @@ func GetHTMLReportCommand() *cobra.Command {
 
 				rulesetFlag, _ := cmd.Flags().GetString("ruleset")
 				resultSet, ruleset, err = BuildResultsWithDocCheckSkip(false, hardModeFlag, rulesetFlag, specBytes, customFunctions,
-					baseFlag, skipCheckFlag, time.Duration(timeoutFlag)*time.Second)
+					baseFlag, remoteFlag, skipCheckFlag, time.Duration(timeoutFlag)*time.Second)
 				if err != nil {
 					pterm.Error.Printf("Failed to generate report: %v\n\n", err)
 					return err

cmd/spectral_report.go

@@ -47,6 +47,7 @@ func GetSpectralReportCommand() *cobra.Command {
 			timeoutFlag, _ := cmd.Flags().GetInt("timeout")
 			hardModeFlag, _ := cmd.Flags().GetBool("hard-mode")
 			extensionRefsFlag, _ := cmd.Flags().GetBool("ext-refs")
+			remoteFlag, _ := cmd.Flags().GetBool("remote")
 
 			// disable color and styling, for CI/CD use.
 			// https://github.com/daveshanley/vacuum/issues/234
@@ -157,6 +158,7 @@ func GetSpectralReportCommand() *cobra.Command {
 				CustomFunctions:                 customFunctions,
 				SilenceLogs:                     true,
 				Base:                            baseFlag,
+				AllowLookup:                     remoteFlag,
 				SkipDocumentCheck:               skipCheckFlag,
 				Timeout:                         time.Duration(timeoutFlag) * time.Second,
 				ExtractReferencesFromExtensions: extensionRefsFlag,

cmd/vacuum_report.go

@@ -50,6 +50,7 @@ func GetVacuumReportCommand() *cobra.Command {
 			ignoreFile, _ := cmd.Flags().GetString("ignore-file")
 			extensionRefsFlag, _ := cmd.Flags().GetBool("ext-refs")
 			minScore, _ := cmd.Flags().GetInt("min-score")
+			remoteFlag, _ := cmd.Flags().GetBool("remote")
 
 			// disable color and styling, for CI/CD use.
 			// https://github.com/daveshanley/vacuum/issues/234
@@ -179,6 +180,7 @@ func GetVacuumReportCommand() *cobra.Command {
 				CustomFunctions:                 customFunctions,
 				SilenceLogs:                     true,
 				Base:                            baseFlag,
+				AllowLookup:                     remoteFlag,
 				SkipDocumentCheck:               skipCheckFlag,
 				BuildDeepGraph:                  deepGraph,
 				Timeout:                         time.Duration(timeoutFlag) * time.Second,