From 5d67705e4a81f94b7b921b7e37ceef91e36554c0 Mon Sep 17 00:00:00 2001 From: Alex Ott Date: Mon, 30 Jun 2025 09:38:35 +0200 Subject: [PATCH] [Internal] Enable Apps integration test on GCP Apps are now available on GCP, so it makes sense to enable tests there as well NO_CHANGELOG=true --- .../providers/pluginfw/products/app/data_app_acc_test.go | 3 --- .../providers/pluginfw/products/app/data_apps_acc_test.go | 3 --- .../pluginfw/products/app/resource_app_acc_test.go | 6 ------ permissions/permissions_test.go | 3 --- 4 files changed, 15 deletions(-) diff --git a/internal/providers/pluginfw/products/app/data_app_acc_test.go b/internal/providers/pluginfw/products/app/data_app_acc_test.go index 024bd36ad9..35af2c4daa 100644 --- a/internal/providers/pluginfw/products/app/data_app_acc_test.go +++ b/internal/providers/pluginfw/products/app/data_app_acc_test.go @@ -33,9 +33,6 @@ const fastApp = ` func TestAccAppDataSource(t *testing.T) { acceptance.LoadWorkspaceEnv(t) - if acceptance.IsGcp(t) { - acceptance.Skipf(t)("not available on GCP") - } acceptance.WorkspaceLevel(t, acceptance.Step{ Template: fastApp + ` data "databricks_app" "this" { diff --git a/internal/providers/pluginfw/products/app/data_apps_acc_test.go b/internal/providers/pluginfw/products/app/data_apps_acc_test.go index 2719f708c4..a46441590c 100644 --- a/internal/providers/pluginfw/products/app/data_apps_acc_test.go +++ b/internal/providers/pluginfw/products/app/data_apps_acc_test.go @@ -8,9 +8,6 @@ import ( func TestAccAppsDataSource(t *testing.T) { acceptance.LoadWorkspaceEnv(t) - if acceptance.IsGcp(t) { - acceptance.Skipf(t)("not available on GCP") - } acceptance.WorkspaceLevel(t, acceptance.Step{ Template: ` data "databricks_apps" "this" { } diff --git a/internal/providers/pluginfw/products/app/resource_app_acc_test.go b/internal/providers/pluginfw/products/app/resource_app_acc_test.go index 2ea3dcdfcb..fd33f63c89 100644 --- a/internal/providers/pluginfw/products/app/resource_app_acc_test.go +++ b/internal/providers/pluginfw/products/app/resource_app_acc_test.go @@ -122,9 +122,6 @@ is required`)), func TestAccAppResource(t *testing.T) { var updateTime string acceptance.LoadWorkspaceEnv(t) - if acceptance.IsGcp(t) { - acceptance.Skipf(t)("not available on GCP") - } acceptance.WorkspaceLevel(t, acceptance.Step{ Template: makeTemplate("My app"), Check: func(s *terraform.State) error { @@ -150,9 +147,6 @@ func TestAccAppResource(t *testing.T) { func TestAccAppResource_NoCompute(t *testing.T) { acceptance.LoadWorkspaceEnv(t) - if acceptance.IsGcp(t) { - acceptance.Skipf(t)("not available on GCP") - } acceptance.WorkspaceLevel(t, acceptance.Step{ Template: ` resource "databricks_secret_scope" "this" { diff --git a/permissions/permissions_test.go b/permissions/permissions_test.go index 4c184d6d99..58afcab255 100644 --- a/permissions/permissions_test.go +++ b/permissions/permissions_test.go @@ -991,9 +991,6 @@ func TestAccPermissions_Query(t *testing.T) { func TestAccPermissions_App(t *testing.T) { acceptance.LoadDebugEnvIfRunsFromIDE(t, "workspace") - if acceptance.IsGcp(t) { - acceptance.Skipf(t)("not available on GCP") - } queryTemplate := ` resource "databricks_app" "this" { name = "{var.RANDOM}"