diff --git a/checkstyle.xml b/checkstyle.xml index e1d5dfbecb..aee0256ef4 100644 --- a/checkstyle.xml +++ b/checkstyle.xml @@ -112,6 +112,7 @@ + @@ -287,4 +288,5 @@ + diff --git a/dapr-spring/dapr-spring-boot-autoconfigure/src/main/java/io/dapr/spring/boot/autoconfigure/client/DaprClientProperties.java b/dapr-spring/dapr-spring-boot-autoconfigure/src/main/java/io/dapr/spring/boot/autoconfigure/client/DaprClientProperties.java index 135416946b..6fb67d5638 100644 --- a/dapr-spring/dapr-spring-boot-autoconfigure/src/main/java/io/dapr/spring/boot/autoconfigure/client/DaprClientProperties.java +++ b/dapr-spring/dapr-spring-boot-autoconfigure/src/main/java/io/dapr/spring/boot/autoconfigure/client/DaprClientProperties.java @@ -23,7 +23,6 @@ public class DaprClientProperties { private Integer httpPort; private Integer grpcPort; - /** * Constructs a {@link DaprClientProperties}. */ diff --git a/dapr-spring/dapr-spring-boot-autoconfigure/src/main/java/io/dapr/spring/boot/autoconfigure/pubsub/DaprPubSubProperties.java b/dapr-spring/dapr-spring-boot-autoconfigure/src/main/java/io/dapr/spring/boot/autoconfigure/pubsub/DaprPubSubProperties.java index d598b9c99e..de23cc82b9 100644 --- a/dapr-spring/dapr-spring-boot-autoconfigure/src/main/java/io/dapr/spring/boot/autoconfigure/pubsub/DaprPubSubProperties.java +++ b/dapr-spring/dapr-spring-boot-autoconfigure/src/main/java/io/dapr/spring/boot/autoconfigure/pubsub/DaprPubSubProperties.java @@ -15,7 +15,6 @@ import org.springframework.boot.context.properties.ConfigurationProperties; - @ConfigurationProperties(prefix = DaprPubSubProperties.CONFIG_PREFIX) public class DaprPubSubProperties { diff --git a/dapr-spring/dapr-spring-data/src/main/java/io/dapr/spring/data/MySQLDaprKeyValueAdapter.java b/dapr-spring/dapr-spring-data/src/main/java/io/dapr/spring/data/MySQLDaprKeyValueAdapter.java index 16701ba233..ebe994b8f3 100644 --- a/dapr-spring/dapr-spring-data/src/main/java/io/dapr/spring/data/MySQLDaprKeyValueAdapter.java +++ b/dapr-spring/dapr-spring-data/src/main/java/io/dapr/spring/data/MySQLDaprKeyValueAdapter.java @@ -76,7 +76,6 @@ public MySQLDaprKeyValueAdapter(DaprClient daprClient, ObjectMapper mapper, Stri this.bindingName = bindingName; } - @Override public Iterable getAllOf(String keyspace, Class type) { Assert.hasText(keyspace, "Keyspace must not be empty"); diff --git a/dapr-spring/dapr-spring-data/src/main/java/io/dapr/spring/data/repository/query/DaprPredicate.java b/dapr-spring/dapr-spring-data/src/main/java/io/dapr/spring/data/repository/query/DaprPredicate.java index d681ce8e60..4676dbd7a1 100644 --- a/dapr-spring/dapr-spring-data/src/main/java/io/dapr/spring/data/repository/query/DaprPredicate.java +++ b/dapr-spring/dapr-spring-data/src/main/java/io/dapr/spring/data/repository/query/DaprPredicate.java @@ -18,7 +18,6 @@ public DaprPredicate(PropertyPath path, Object expected) { this(path, expected, (valueToCompare) -> ObjectUtils.nullSafeEquals(valueToCompare, expected)); } - /** * Creates a new {@link DaprPredicate}. * diff --git a/dapr-spring/dapr-spring-messaging/src/main/java/io/dapr/spring/messaging/DaprMessagingTemplate.java b/dapr-spring/dapr-spring-messaging/src/main/java/io/dapr/spring/messaging/DaprMessagingTemplate.java index d8929704e0..df03e1125a 100644 --- a/dapr-spring/dapr-spring-messaging/src/main/java/io/dapr/spring/messaging/DaprMessagingTemplate.java +++ b/dapr-spring/dapr-spring-messaging/src/main/java/io/dapr/spring/messaging/DaprMessagingTemplate.java @@ -192,7 +192,6 @@ public SendMessageBuilder withTopic(String topic) { return this; } - @Override public void send() { template.doSend(topic, message); @@ -202,7 +201,5 @@ public void send() { public Mono sendAsync() { return template.doSendAsync(topic, message); } - } - } diff --git a/dapr-spring/dapr-spring-messaging/src/main/java/io/dapr/spring/messaging/observation/DaprMessagingSenderContext.java b/dapr-spring/dapr-spring-messaging/src/main/java/io/dapr/spring/messaging/observation/DaprMessagingSenderContext.java index 5397b7a64f..3b830872cb 100644 --- a/dapr-spring/dapr-spring-messaging/src/main/java/io/dapr/spring/messaging/observation/DaprMessagingSenderContext.java +++ b/dapr-spring/dapr-spring-messaging/src/main/java/io/dapr/spring/messaging/observation/DaprMessagingSenderContext.java @@ -58,7 +58,6 @@ public Map properties() { return carrier.properties(); } - /** * The name of the bean sending the message (typically a {@code DaprMessagingTemplate}). * @return the name of the bean sending the message @@ -75,7 +74,6 @@ public String getDestination() { return this.destination; } - /** * Acts as a carrier for a Dapr message and records the propagated properties for * later access by the Dapr. diff --git a/dapr-spring/dapr-spring-workflows/src/main/java/io/dapr/spring/workflows/config/EnableDaprWorkflows.java b/dapr-spring/dapr-spring-workflows/src/main/java/io/dapr/spring/workflows/config/EnableDaprWorkflows.java index e5572f6f73..33be646741 100644 --- a/dapr-spring/dapr-spring-workflows/src/main/java/io/dapr/spring/workflows/config/EnableDaprWorkflows.java +++ b/dapr-spring/dapr-spring-workflows/src/main/java/io/dapr/spring/workflows/config/EnableDaprWorkflows.java @@ -1,6 +1,5 @@ package io.dapr.spring.workflows.config; - import org.springframework.context.annotation.Import; import java.lang.annotation.Retention; diff --git a/examples/src/main/java/io/dapr/examples/workflows/childworkflow/DemoChildWorkflow.java b/examples/src/main/java/io/dapr/examples/workflows/childworkflow/DemoChildWorkflow.java index 4c1ac8ddb4..1d4efbdfe7 100644 --- a/examples/src/main/java/io/dapr/examples/workflows/childworkflow/DemoChildWorkflow.java +++ b/examples/src/main/java/io/dapr/examples/workflows/childworkflow/DemoChildWorkflow.java @@ -13,6 +13,7 @@ package io.dapr.examples.workflows.childworkflow; +import io.dapr.durabletask.interruption.OrchestratorBlockedException; import io.dapr.workflows.Workflow; import io.dapr.workflows.WorkflowStub; import io.dapr.workflows.WorkflowTaskOptions; diff --git a/sdk-actors/src/main/java/io/dapr/actors/ActorId.java b/sdk-actors/src/main/java/io/dapr/actors/ActorId.java index e56f6702dd..06dc4f6714 100644 --- a/sdk-actors/src/main/java/io/dapr/actors/ActorId.java +++ b/sdk-actors/src/main/java/io/dapr/actors/ActorId.java @@ -123,7 +123,6 @@ public static ActorId createRandom() { return new ActorId(id.toString()); } - /** * Compares if two actors have the same content. * diff --git a/sdk-actors/src/main/java/io/dapr/actors/client/ActorClient.java b/sdk-actors/src/main/java/io/dapr/actors/client/ActorClient.java index 1fe2d4f19d..ecdf60b4bf 100644 --- a/sdk-actors/src/main/java/io/dapr/actors/client/ActorClient.java +++ b/sdk-actors/src/main/java/io/dapr/actors/client/ActorClient.java @@ -130,7 +130,6 @@ public void close() { } } - /** * Build an instance of the Client based on the provided setup. * diff --git a/sdk-springboot/src/main/java/io/dapr/springboot/DaprController.java b/sdk-springboot/src/main/java/io/dapr/springboot/DaprController.java index 1fe77e955d..35794e826d 100644 --- a/sdk-springboot/src/main/java/io/dapr/springboot/DaprController.java +++ b/sdk-springboot/src/main/java/io/dapr/springboot/DaprController.java @@ -13,7 +13,6 @@ package io.dapr.springboot; - import io.dapr.actors.runtime.ActorRuntime; import io.dapr.serializer.DefaultObjectSerializer; import org.springframework.http.MediaType; @@ -124,5 +123,4 @@ public Mono invokeActorReminder(@PathVariable("type") String type, @RequestBody(required = false) byte[] body) { return ActorRuntime.getInstance().invokeReminder(type, id, reminder, body); } - } diff --git a/sdk-springboot/src/main/java/io/dapr/springboot/DaprTopicSubscription.java b/sdk-springboot/src/main/java/io/dapr/springboot/DaprTopicSubscription.java index 6d9ee0d3d0..16904a105f 100644 --- a/sdk-springboot/src/main/java/io/dapr/springboot/DaprTopicSubscription.java +++ b/sdk-springboot/src/main/java/io/dapr/springboot/DaprTopicSubscription.java @@ -123,7 +123,6 @@ class DaprTopicSubscription { this(pubsubName, topic, route, "", routes, metadata, bulkSubscribe); } - /** * Create a subscription topic. * diff --git a/sdk-workflows/src/main/java/io/dapr/workflows/runtime/WorkflowActivityClassWrapper.java b/sdk-workflows/src/main/java/io/dapr/workflows/runtime/WorkflowActivityClassWrapper.java index 0bbfd4beb9..2c4c5b17a9 100644 --- a/sdk-workflows/src/main/java/io/dapr/workflows/runtime/WorkflowActivityClassWrapper.java +++ b/sdk-workflows/src/main/java/io/dapr/workflows/runtime/WorkflowActivityClassWrapper.java @@ -48,7 +48,6 @@ public String getName() { return name; } - @Override public TaskActivity create() { return ctx -> { diff --git a/sdk-workflows/src/main/java/io/dapr/workflows/runtime/WorkflowRuntime.java b/sdk-workflows/src/main/java/io/dapr/workflows/runtime/WorkflowRuntime.java index 7ac44e0001..09f831a563 100644 --- a/sdk-workflows/src/main/java/io/dapr/workflows/runtime/WorkflowRuntime.java +++ b/sdk-workflows/src/main/java/io/dapr/workflows/runtime/WorkflowRuntime.java @@ -94,4 +94,4 @@ private void shutDownWorkerPool() { Thread.currentThread().interrupt(); } } -} \ No newline at end of file +} diff --git a/sdk/src/main/java/io/dapr/client/AbstractDaprClient.java b/sdk/src/main/java/io/dapr/client/AbstractDaprClient.java index 628a4c5ab9..203f3f00a2 100644 --- a/sdk/src/main/java/io/dapr/client/AbstractDaprClient.java +++ b/sdk/src/main/java/io/dapr/client/AbstractDaprClient.java @@ -655,7 +655,6 @@ public Mono unlock(String storeName, String resourceId, St return this.unlock(request); } - private List filterEmptyKeys(String... keys) { return Arrays.stream(keys) .filter(key -> !key.trim().isEmpty()) diff --git a/sdk/src/main/java/io/dapr/client/GrpcChannelFacade.java b/sdk/src/main/java/io/dapr/client/GrpcChannelFacade.java index 5647f5294c..13594e4c60 100644 --- a/sdk/src/main/java/io/dapr/client/GrpcChannelFacade.java +++ b/sdk/src/main/java/io/dapr/client/GrpcChannelFacade.java @@ -32,7 +32,6 @@ class GrpcChannelFacade implements Closeable { */ private final ManagedChannel channel; - /** * Default access level constructor, in order to create an instance of this class use io.dapr.client.DaprClientBuilder * diff --git a/sdk/src/main/java/io/dapr/client/domain/BulkPublishEntry.java b/sdk/src/main/java/io/dapr/client/domain/BulkPublishEntry.java index 57ba826090..d9aa70819d 100644 --- a/sdk/src/main/java/io/dapr/client/domain/BulkPublishEntry.java +++ b/sdk/src/main/java/io/dapr/client/domain/BulkPublishEntry.java @@ -81,7 +81,6 @@ public T getEvent() { return event; } - public String getContentType() { return contentType; } diff --git a/sdk/src/main/java/io/dapr/client/domain/BulkSubscribeAppResponseStatus.java b/sdk/src/main/java/io/dapr/client/domain/BulkSubscribeAppResponseStatus.java index 0b4cb5ccf8..1f0ec0a773 100644 --- a/sdk/src/main/java/io/dapr/client/domain/BulkSubscribeAppResponseStatus.java +++ b/sdk/src/main/java/io/dapr/client/domain/BulkSubscribeAppResponseStatus.java @@ -20,4 +20,4 @@ public enum BulkSubscribeAppResponseStatus { SUCCESS, RETRY, DROP -} \ No newline at end of file +} diff --git a/sdk/src/main/java/io/dapr/client/domain/BulkSubscribeMessage.java b/sdk/src/main/java/io/dapr/client/domain/BulkSubscribeMessage.java index 1c1058292a..81bb26495d 100644 --- a/sdk/src/main/java/io/dapr/client/domain/BulkSubscribeMessage.java +++ b/sdk/src/main/java/io/dapr/client/domain/BulkSubscribeMessage.java @@ -55,4 +55,4 @@ public String getTopic() { public Map getMetadata() { return metadata; } -} \ No newline at end of file +} diff --git a/sdk/src/main/java/io/dapr/client/domain/LockRequest.java b/sdk/src/main/java/io/dapr/client/domain/LockRequest.java index af6dcdb7b6..29f64e1b13 100644 --- a/sdk/src/main/java/io/dapr/client/domain/LockRequest.java +++ b/sdk/src/main/java/io/dapr/client/domain/LockRequest.java @@ -13,7 +13,6 @@ package io.dapr.client.domain; - import com.fasterxml.jackson.annotation.JsonIgnore; import java.io.Serializable; diff --git a/sdk/src/main/java/io/dapr/client/domain/QueryStateItem.java b/sdk/src/main/java/io/dapr/client/domain/QueryStateItem.java index 093299eed9..1813f86987 100644 --- a/sdk/src/main/java/io/dapr/client/domain/QueryStateItem.java +++ b/sdk/src/main/java/io/dapr/client/domain/QueryStateItem.java @@ -13,10 +13,8 @@ package io.dapr.client.domain; - public class QueryStateItem { - /** * The value of the state. */ diff --git a/sdk/src/main/java/io/dapr/client/domain/QueryStateResponse.java b/sdk/src/main/java/io/dapr/client/domain/QueryStateResponse.java index e084a45661..f9869d0075 100644 --- a/sdk/src/main/java/io/dapr/client/domain/QueryStateResponse.java +++ b/sdk/src/main/java/io/dapr/client/domain/QueryStateResponse.java @@ -13,7 +13,6 @@ package io.dapr.client.domain; - import java.util.Collections; import java.util.List; import java.util.Map; diff --git a/sdk/src/main/java/io/dapr/client/domain/UnlockResponseStatus.java b/sdk/src/main/java/io/dapr/client/domain/UnlockResponseStatus.java index 726e338697..c3b6c9ccf3 100644 --- a/sdk/src/main/java/io/dapr/client/domain/UnlockResponseStatus.java +++ b/sdk/src/main/java/io/dapr/client/domain/UnlockResponseStatus.java @@ -13,7 +13,6 @@ package io.dapr.client.domain; - public enum UnlockResponseStatus { /** diff --git a/sdk/src/main/java/io/dapr/client/domain/query/Query.java b/sdk/src/main/java/io/dapr/client/domain/query/Query.java index 98f54e3b26..c6ac8c40cb 100644 --- a/sdk/src/main/java/io/dapr/client/domain/query/Query.java +++ b/sdk/src/main/java/io/dapr/client/domain/query/Query.java @@ -72,4 +72,4 @@ public Query setPagination(Pagination pagination) { this.pagination = pagination; return this; } -} \ No newline at end of file +} diff --git a/sdk/src/main/java/io/dapr/config/Properties.java b/sdk/src/main/java/io/dapr/config/Properties.java index 7287dbcdf2..85110c1922 100644 --- a/sdk/src/main/java/io/dapr/config/Properties.java +++ b/sdk/src/main/java/io/dapr/config/Properties.java @@ -254,8 +254,6 @@ public class Properties { "DAPR_HTTP_CLIENT_MAX_IDLE_CONNECTIONS", DEFAULT_HTTP_CLIENT_MAX_IDLE_CONNECTIONS); - - /** * Dapr's default maximum inbound message size for GRPC in bytes. */ diff --git a/sdk/src/main/java/io/dapr/exceptions/DaprErrorDetails.java b/sdk/src/main/java/io/dapr/exceptions/DaprErrorDetails.java index ee1d182f84..fd766dad58 100644 --- a/sdk/src/main/java/io/dapr/exceptions/DaprErrorDetails.java +++ b/sdk/src/main/java/io/dapr/exceptions/DaprErrorDetails.java @@ -217,5 +217,4 @@ public enum ErrorDetailType { HELP, LOCALIZED_MESSAGE, } - -} \ No newline at end of file +} diff --git a/sdk/src/main/java/io/dapr/internal/grpc/interceptors/DaprMetadataReceiverInterceptor.java b/sdk/src/main/java/io/dapr/internal/grpc/interceptors/DaprMetadataReceiverInterceptor.java index 9e564536aa..95a62f1696 100644 --- a/sdk/src/main/java/io/dapr/internal/grpc/interceptors/DaprMetadataReceiverInterceptor.java +++ b/sdk/src/main/java/io/dapr/internal/grpc/interceptors/DaprMetadataReceiverInterceptor.java @@ -62,7 +62,4 @@ public void onHeaders(Metadata headers) { } }; } - - - } diff --git a/sdk/src/main/java/io/dapr/utils/DefaultContentTypeConverter.java b/sdk/src/main/java/io/dapr/utils/DefaultContentTypeConverter.java index e820093ce9..083ed2c70d 100644 --- a/sdk/src/main/java/io/dapr/utils/DefaultContentTypeConverter.java +++ b/sdk/src/main/java/io/dapr/utils/DefaultContentTypeConverter.java @@ -13,7 +13,6 @@ package io.dapr.utils; - import io.dapr.serializer.DefaultObjectSerializer; import java.io.IOException; @@ -145,7 +144,6 @@ public static boolean isCloudEventContentType(String contentType) { return isContentType(contentType, "application/cloudevents+json"); } - public static boolean isJsonContentType(String contentType) { return isContentType(contentType, "application/json"); } diff --git a/sdk/src/main/java/io/dapr/utils/NetworkUtils.java b/sdk/src/main/java/io/dapr/utils/NetworkUtils.java index 49b206aeb6..af0e26f80b 100644 --- a/sdk/src/main/java/io/dapr/utils/NetworkUtils.java +++ b/sdk/src/main/java/io/dapr/utils/NetworkUtils.java @@ -50,7 +50,6 @@ import static io.dapr.config.Properties.GRPC_TLS_KEY_PATH; import static io.dapr.config.Properties.SIDECAR_IP; - /** * Utility methods for network, internal to Dapr SDK. */ @@ -382,4 +381,4 @@ public static String getHostLoopbackAddress() { static boolean isIPv6(String ip) { return IPV6_PATTERN.matcher(ip).matches(); } -} \ No newline at end of file +}