Skip to content

Commit b4ede86

Browse files
committed
Update CNI and CNI plugins
Signed-off-by: Sascha Grunert <[email protected]>
1 parent e9f625a commit b4ede86

File tree

8 files changed

+195
-84
lines changed

8 files changed

+195
-84
lines changed

go.mod

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,8 +3,8 @@ module github.com/cri-o/ocicni
33
go 1.24
44

55
require (
6-
github.com/containernetworking/cni v1.2.3
7-
github.com/containernetworking/plugins v1.6.2
6+
github.com/containernetworking/cni v1.3.0
7+
github.com/containernetworking/plugins v1.7.1
88
github.com/fsnotify/fsnotify v1.9.0
99
github.com/onsi/ginkgo/v2 v2.24.0
1010
github.com/onsi/gomega v1.38.0

go.sum

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,9 @@
11
github.com/Masterminds/semver/v3 v3.3.1 h1:QtNSWtVZ3nBfk8mAOu/B6v7FMJ+NHTIgUPi7rj+4nv4=
22
github.com/Masterminds/semver/v3 v3.3.1/go.mod h1:4V+yj/TJE1HU9XfppCwVMZq3I84lprf4nC11bSS5beM=
3-
github.com/containernetworking/cni v1.2.3 h1:hhOcjNVUQTnzdRJ6alC5XF+wd9mfGIUaj8FuJbEslXM=
4-
github.com/containernetworking/cni v1.2.3/go.mod h1:DuLgF+aPd3DzcTQTtp/Nvl1Kim23oFKdm2okJzBQA5M=
5-
github.com/containernetworking/plugins v1.6.2 h1:pqP8Mq923TLyef5g97XfJ/xpDeVek4yF8A4mzy9Tc4U=
6-
github.com/containernetworking/plugins v1.6.2/go.mod h1:SP5UG3jDO9LtmfbBJdP+nl3A1atOtbj2MBOYsnaxy64=
3+
github.com/containernetworking/cni v1.3.0 h1:v6EpN8RznAZj9765HhXQrtXgX+ECGebEYEmnuFjskwo=
4+
github.com/containernetworking/cni v1.3.0/go.mod h1:Bs8glZjjFfGPHMw6hQu82RUgEPNGEaBb9KS5KtNMnJ4=
5+
github.com/containernetworking/plugins v1.7.1 h1:CNAR0jviDj6FS5Vg85NTgKWLDzZPfi/lj+VJfhMDTIs=
6+
github.com/containernetworking/plugins v1.7.1/go.mod h1:xuMdjuio+a1oVQsHKjr/mgzuZ24leAsqUYRnzGoXHy0=
77
github.com/davecgh/go-spew v1.1.0/go.mod h1:J7Y8YcW2NihsgmVo/mv3lAwl/skON4iLHjSsI+c5H38=
88
github.com/davecgh/go-spew v1.1.1 h1:vj9j/u1bqnvCEfJOwUhtlOARqs3+rkHYY13jYWTU97c=
99
github.com/davecgh/go-spew v1.1.1/go.mod h1:J7Y8YcW2NihsgmVo/mv3lAwl/skON4iLHjSsI+c5H38=

pkg/ocicni/ocicni.go

Lines changed: 17 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -336,7 +336,14 @@ func loadNetworks(ctx context.Context, confDir string, cni *libcni.CNIConfig) (n
336336
continue
337337
}
338338
} else {
339-
conf, err := libcni.ConfFromFile(confFile)
339+
bytes, err := os.ReadFile(confFile)
340+
if err != nil {
341+
logrus.Errorf("Error loading CNI config file %s: %v", confFile, err)
342+
343+
continue
344+
}
345+
346+
conf, err := libcni.NetworkPluginConfFromBytes(bytes)
340347
if err != nil {
341348
// do not log ENOENT errors
342349
if !os.IsNotExist(err) {
@@ -352,6 +359,7 @@ func loadNetworks(ctx context.Context, confDir string, cni *libcni.CNIConfig) (n
352359
continue
353360
}
354361

362+
//nolint:staticcheck // we still require this function
355363
confList, err = libcni.ConfListFromConf(conf)
356364
if err != nil {
357365
logrus.Errorf("Error converting CNI config file %s to list: %v", confFile, err)
@@ -487,18 +495,19 @@ func (plugin *cniNetworkPlugin) loadNetworkFromCache(name string, rt *libcni.Run
487495
return nil, nil, fmt.Errorf("network %q not found in CNI cache", name)
488496
}
489497

490-
cniNet.config, err = libcni.ConfListFromBytes(confBytes)
498+
cniNet.config, err = libcni.NetworkConfFromBytes(confBytes)
491499
if err != nil {
500+
return nil, nil, err
501+
}
502+
503+
if cniNet.config.Plugins == nil {
492504
// Might be a plain NetworkConfig
493-
netConf, err := libcni.ConfFromBytes(confBytes)
494-
if err != nil {
495-
return nil, nil, err
496-
}
497-
// Up-convert to a NetworkConfigList
498-
cniNet.config, err = libcni.ConfListFromConf(netConf)
505+
netConf, err := libcni.NetworkPluginConfFromBytes(confBytes)
499506
if err != nil {
500507
return nil, nil, err
501508
}
509+
510+
cniNet.config.Plugins = []*libcni.PluginConfig{netConf}
502511
}
503512

504513
return cniNet, rt, nil

vendor/github.com/containernetworking/cni/libcni/api.go

Lines changed: 33 additions & 28 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)