Merge pull request #9269 from Luap99/rootfs-shell-completion

openshift-merge-robot · web-flow · commit 9da4169e312b · 2021-02-09T04:25:30.000-05:00
Allow path completion for podman create/run --rootfs
diff --git a/cmd/podman/common/completion.go b/cmd/podman/common/completion.go
@@ -426,6 +426,12 @@ func AutocompleteCreateRun(cmd *cobra.Command, args []string, toComplete string)
 		return nil, cobra.ShellCompDirectiveNoFileComp
 	}
 	if len(args) < 1 {
+		// check if the rootfs flag is set
+		// if it is set to true provide directory completion
+		rootfs, err := cmd.Flags().GetBool("rootfs")
+		if err == nil && rootfs {
+			return nil, cobra.ShellCompDirectiveFilterDirs
+		}
 		return getImages(cmd, toComplete)
 	}
 	// TODO: add path completion for files in the image

Original file line number	Diff line number	Diff line change
`@@ -426,6 +426,12 @@ func AutocompleteCreateRun(cmd *cobra.Command, args []string, toComplete string)`
`426`	`426`	`return nil, cobra.ShellCompDirectiveNoFileComp`
`427`	`427`	`}`
`428`	`428`	`if len(args) < 1 {`
	`429`	`+ // check if the rootfs flag is set`
	`430`	`+ // if it is set to true provide directory completion`
	`431`	`+ rootfs, err := cmd.Flags().GetBool("rootfs")`
	`432`	`+ if err == nil && rootfs {`
	`433`	`+ return nil, cobra.ShellCompDirectiveFilterDirs`
	`434`	`+ }`
`429`	`435`	`return getImages(cmd, toComplete)`
`430`	`436`	`}`
`431`	`437`	`// TODO: add path completion for files in the image`