Skip to content

Commit 5a632c9

Browse files
authored
Allow Firebase release not to have displayVersion attribute (#474)
1 parent 249ceda commit 5a632c9

File tree

5 files changed

+19
-7
lines changed

5 files changed

+19
-7
lines changed

CHANGELOG.md

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,14 @@
1+
Version 0.60.2
2+
-------------
3+
4+
**Bugfixes**
5+
- Fix `TypeError` in `firebase-app-distribution` actions if Firebase release response is missing `displayVersion` attribute. [PR #474](https://github.com/codemagic-ci-cd/cli-tools/pull/474)
6+
17
Version 0.60.1
28
-------------
39

410
**Bugfixes**
5-
- Fix action `firebase-app-distribution-debug get-latest-build-version` by supporting new `updateTime` and `expireTime` timestamps for releases. [PR #473](https://github.com/codemagic-ci-cd/cli-tools/pull/473)
11+
- Fix action `firebase-app-distribution get-latest-build-version` by supporting new `updateTime` and `expireTime` timestamps for releases. [PR #473](https://github.com/codemagic-ci-cd/cli-tools/pull/473)
612

713
Version 0.60.0
814
-------------

pyproject.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
[tool.poetry]
22
name = "codemagic-cli-tools"
3-
version = "0.60.1"
3+
version = "0.60.2"
44
description = "CLI tools used in Codemagic builds"
55
readme = "README.md"
66
authors = [

src/codemagic/__version__.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
__title__ = "codemagic-cli-tools"
22
__description__ = "CLI tools used in Codemagic builds"
3-
__version__ = "0.60.1.dev"
3+
__version__ = "0.60.2.dev"
44
__url__ = "https://github.com/codemagic-ci-cd/cli-tools"
55
__licence__ = "GNU General Public License v3.0"

src/codemagic/google/resources/firebase/release.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,12 +18,12 @@ class Release(Resource):
1818
"""
1919

2020
name: str
21-
displayVersion: str
22-
buildVersion: str
2321
createTime: datetime
2422
firebaseConsoleUri: str
2523
testingUri: str
2624
binaryDownloadUri: str
25+
buildVersion: str
26+
displayVersion: str = ""
2727
releaseNotes: Optional[ReleaseNotes] = None
2828
updateTime: Optional[datetime] = None
2929
expireTime: Optional[datetime] = None

tests/google/resources/firebase/test_release.py

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,17 +10,23 @@ def test_release_initialization(api_firebase_release: dict):
1010
assert release.dict() == api_firebase_release
1111

1212

13+
def test_release_without_display_version(api_firebase_release: dict):
14+
api_firebase_release.pop("displayVersion", None)
15+
release = Release(**api_firebase_release)
16+
assert release.displayVersion == ""
17+
18+
1319
def test_release_string_representation(api_firebase_release: dict):
1420
release = Release(**api_firebase_release)
1521
expected = textwrap.dedent(
1622
"""
1723
Name: projects/146661841143/apps/1:146661841143:android:a8d456e0c8b5e71bd11bf2/releases/78ruoe1t1uvr8
18-
Display version: 1.0
19-
Build version: 1
2024
Create time: 2025-02-12T14:12:59.510381+00:00
2125
Firebase console URI: https://console.firebase.google.com/project/codemagic-cli-tools-test-app/appdistribution/app/android:io.codemagic.cli_tools_firebase/releases/78ruoe1t1uvr8
2226
Testing URI: https://appdistribution.firebase.google.com/testerapps/1:146661841143:android:a8d456e0c8b5e71bd11bf2/releases/78ruoe1t1uvr8
2327
Binary download URI: https://firebaseappdistribution.googleapis.com/app-binary-downloads/projects/146661841143/apps/1:146661841143:android:a8d456e0c8b5e71bd11bf2/releases/78ruoe1t1uvr8/binaries/fcdd844be2bd504ae7bb9d672731ddbfcd89c1419a9aa746a0bb6f67d3a1429d/app.apk?token=token
28+
Build version: 1
29+
Display version: 1.0
2430
Release notes:
2531
Text: My release notes
2632
Update time: 2025-08-25T07:04:39.166957+00:00

0 commit comments

Comments
 (0)