Fix gitlab crash on bogus response

Author: prymitive

internal/reporter/comments.go

@@ -335,6 +335,10 @@ func updateDestination(ctx context.Context, s Summary, c Commenter, dst any, sho
 		if !c.CanDelete(existing) {
 			goto NEXTDelete
 		}
+		slog.Info("Trying to delete a stale existing comment",
+			slog.String("path", existing.path),
+			slog.Int("line", existing.line),
+		)
 		if err := c.Delete(ctx, dst, existing); err != nil {
 			slog.Error("Failed to delete a stale comment",
 				slog.String("reporter", c.Describe()),

internal/reporter/gitlab.go

@@ -191,7 +191,9 @@ func (gl GitLabReporter) List(_ context.Context, dst any) ([]ExistingComment, er
 			c = gl.noteToExisting(disc.ID, note)
 			break
 		}
-		comments = append(comments, c)
+		if c.path != "" && c.line > 0 && c.meta != nil {
+			comments = append(comments, c)
+		}
 	NEXT:
 	}
 	return comments, nil

internal/reporter/gitlab_test.go

@@ -8,6 +8,7 @@ import (
 	"net/http/httptest"
 	"os"
 	"path/filepath"
+	"regexp"
 	"strconv"
 	"strings"
 	"testing"
@@ -234,6 +235,19 @@ func TestGitLabReporter(t *testing.T) {
 		maxComments    int
 		showDuplicates bool
 	}{
+		{
+			description: "bogus JSON responses",
+			timeout:     time.Minute,
+			maxComments: 1,
+			summary:     reporter.NewSummary([]reporter.Report{fooReport}),
+			mock: httpmock.New(func(s *httpmock.Server) {
+				s.ExpectGet(apiUser).ReturnJSON(gitlab.User{ID: 123})
+				s.ExpectGet(regexp.MustCompile(".+")).Times(4).Return(`[{"iid": 333}]`)
+			}),
+			errorHandler: func(err error) error {
+				return err
+			},
+		},
 		{
 			description: "empty list of merge requests",
 			timeout:     time.Minute,