Merge pull request #5763 from epage/complete

epage · web-flow · commit d6bd7e2ea658 · 2024-10-02T10:31:17.000-04:00
fix(complete): Change ValueHint::Unknown to Other, from AnyPath
diff --git a/clap_complete/src/engine/complete.rs b/clap_complete/src/engine/complete.rs
@@ -329,10 +329,10 @@ fn complete_arg_value(
         }
     } else {
         match arg.get_value_hint() {
-            clap::ValueHint::Other => {
+            clap::ValueHint::Unknown | clap::ValueHint::Other => {
                 // Should not complete
             }
-            clap::ValueHint::Unknown | clap::ValueHint::AnyPath => {
+            clap::ValueHint::AnyPath => {
                 values.extend(complete_path(value_os, current_dir, &|_| true));
             }
             clap::ValueHint::FilePath => {

Original file line number	Diff line number	Diff line change
`@@ -329,10 +329,10 @@ fn complete_arg_value(`
`329`	`329`	`}`
`330`	`330`	`} else {`
`331`	`331`	`match arg.get_value_hint() {`
`332`		`- clap::ValueHint::Other => {`
	`332`	`+ clap::ValueHint::Unknown \| clap::ValueHint::Other => {`
`333`	`333`	`// Should not complete`
`334`	`334`	`}`
`335`		`- clap::ValueHint::Unknown \| clap::ValueHint::AnyPath => {`
	`335`	`+ clap::ValueHint::AnyPath => {`
`336`	`336`	`values.extend(complete_path(value_os, current_dir, &\|_\| true));`
`337`	`337`	`}`
`338`	`338`	`clap::ValueHint::FilePath => {`