Fix frames leak when VfsPoll fails

cole-miller · cole-miller · commit 35a324293b45 · 2024-10-17T09:50:27.000-04:00
VfsPoll can fail to acquire the WAL write lock, and the caller still
needs to release the frames of the transaction in this case. Restores
the behavior from before the exec_tick rewrite.

Signed-off-by: Cole Miller &lt;cole.miller@canonical.com&gt;
diff --git a/src/leader.c b/src/leader.c
@@ -467,7 +467,7 @@ static int exec_apply(struct exec *req)
 
 	rv = VfsPoll(vfs, db->path, &frames, &n);
 	if (rv != 0) {
-		return rv;
+		goto finish;
 	}
 	sm_move(&req->sm, EXEC_POLLED);
 	if (n == 0) {

Original file line number	Diff line number	Diff line change
`@@ -467,7 +467,7 @@ static int exec_apply(struct exec *req)`
`467`	`467`
`468`	`468`	`rv = VfsPoll(vfs, db->path, &frames, &n);`
`469`	`469`	`if (rv != 0) {`
`470`		`- return rv;`
	`470`	`+ goto finish;`
`471`	`471`	`}`
`472`	`472`	`sm_move(&req->sm, EXEC_POLLED);`
`473`	`473`	`if (n == 0) {`