reverseproxy: Fix least_conn policy regression (#5862)

francislavoie · web-flow · commit e8b8d4a8cdf1 · 2023-10-11T16:04:28.000Z
diff --git a/modules/caddyhttp/reverseproxy/selectionpolicies.go b/modules/caddyhttp/reverseproxy/selectionpolicies.go
@@ -269,7 +269,7 @@ func (LeastConnSelection) Select(pool UpstreamPool, _ *http.Request, _ http.Resp
 		// sample: https://en.wikipedia.org/wiki/Reservoir_sampling
 		if numReqs == leastReqs {
 			count++
-			if count > 1 || (weakrand.Int()%count) == 0 { //nolint:gosec
+			if count == 1 || (weakrand.Int()%count) == 0 { //nolint:gosec
 				bestHost = host
 			}
 		}

Original file line number	Diff line number	Diff line change
`@@ -269,7 +269,7 @@ func (LeastConnSelection) Select(pool UpstreamPool, _ *http.Request, _ http.Resp`
`269`	`269`	`// sample: https://en.wikipedia.org/wiki/Reservoir_sampling`
`270`	`270`	`if numReqs == leastReqs {`
`271`	`271`	`count++`
`272`		`- if count > 1 \|\| (weakrand.Int()%count) == 0 { //nolint:gosec`
	`272`	`+ if count == 1 \|\| (weakrand.Int()%count) == 0 { //nolint:gosec`
`273`	`273`	`bestHost = host`
`274`	`274`	`}`
`275`	`275`	`}`