feat: timeout is now 20 seconds. Users can now change the timeout length (#1208)

Author: Jaskowicz1

include/dpp/cluster.h

@@ -202,6 +202,11 @@ class DPP_EXPORT cluster {
 	 */
 	std::condition_variable terminating;
 
+	/**
+	 * @brief The time (in seconds) that a request is allowed to take.
+	 */
+	uint16_t request_timeout = 20;
+
 	/**
 	 * @brief Constructor for creating a cluster. All but the token are optional.
 	 * @param token The bot token to use for all HTTP commands and websocket connections
@@ -420,6 +425,15 @@ class DPP_EXPORT cluster {
 	 */
 	const shard_list& get_shards();
 
+	/**
+	 * @brief Sets the request timeout.
+	 *
+	 * @param timeout The length of time (in seconds) that requests are allowed to take. Default: 20.
+	 *
+	 * @return cluster& Reference to self for chaining.
+	 */
+	cluster& set_request_timeout(uint16_t timeout);
+
 	/* Functions for attaching to event handlers */
 
 	/**

include/dpp/queues.h

@@ -296,8 +296,10 @@ class DPP_EXPORT http_request {
 
 	/**
 	 * @brief How many seconds before the connection is considered failed if not finished
+	 *
+	 * @deprecated Please now use dpp::cluster::request_timeout
 	 */
-	time_t request_timeout;
+	DPP_DEPRECATED("Please now use dpp::cluster::request_timeout") time_t request_timeout;
 
 	/**
 	 * @brief Constructor. When constructing one of these objects it should be passed to request_queue::post_request().

src/dpp/cluster.cpp

@@ -456,4 +456,9 @@ const shard_list& cluster::get_shards() {
 	return shards;
 }
 
+cluster& cluster::set_request_timeout(uint16_t timeout) {
+	request_timeout = timeout;
+	return *this;
+}
+
 };

src/dpp/queues.cpp

@@ -176,7 +176,7 @@ http_request_completion_t http_request::run(cluster* owner) {
 	}
 	http_connect_info hci = https_client::get_host_info(_host);
 	try {
-		https_client cli(hci.hostname, hci.port, _url, request_verb[method], multipart.body, headers, !hci.is_ssl, request_timeout, protocol);
+		https_client cli(hci.hostname, hci.port, _url, request_verb[method], multipart.body, headers, !hci.is_ssl, owner->request_timeout, protocol);
 		rv.latency = dpp::utility::time_f() - start;
 		if (cli.timed_out) {
 			rv.error = h_connection;