Skip to content

Commit afb8402

Browse files
committed
reorg: make rules ready for release
When releasing library the best practices recommend that the entire public directory should be buildable without any dev dependencies. This breaks the API as those consuming the library need to change the paths they're using, but it's not that much of a change.
1 parent 43b4866 commit afb8402

21 files changed

+16
-11
lines changed

BUILD.bazel

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
load("@buildifier_prebuilt//:rules.bzl", "buildifier")
2-
load(":workspace_status.bzl", "workspace_status")
2+
load("@rules_booking//booking:workspace_status.bzl", "workspace_status")
33

44
buildifier(
55
name = "buildifier",

MODULE.bazel

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ bazel_dep(name = "bazel_skylib", version = "1.7.1")
1010
bazel_dep(name = "rules_java", version = "6.5.2")
1111
bazel_dep(name = "rules_pkg", version = "1.0.1")
1212

13-
extra_dependencies = use_extension("//:module.bzl", "extra_dependencies")
13+
extra_dependencies = use_extension("//booking:module.bzl", "extra_dependencies")
1414
use_repo(
1515
extra_dependencies,
1616
"bazel_version",
File renamed without changes.

dependencies.bzl renamed to booking/dependencies.bzl

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
11
load("@bazel_skylib//:workspace.bzl", "bazel_skylib_workspace")
22
load("@rules_java//java:repositories.bzl", "rules_java_dependencies", "rules_java_toolchains")
33
load("@rules_pkg//:deps.bzl", "rules_pkg_dependencies")
4-
load("//:repositories.bzl", "bazel_version")
5-
load("//dependency_check:deps.bzl", _dependency_check = "dependencies")
4+
load("//booking:repositories.bzl", "bazel_version")
5+
load("//booking/dependency_check:deps.bzl", _dependency_check = "dependencies")
66

77
def dependencies():
88
bazel_skylib_workspace()
File renamed without changes.
File renamed without changes.

dependency_check/deps.bzl renamed to booking/dependency_check/deps.bzl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,5 +10,5 @@ def dependencies():
1010
urls = [
1111
"https://github.com/jeremylong/DependencyCheck/releases/download/v8.4.0/dependency-check-8.4.0-release.zip",
1212
],
13-
build_file = "@rules_booking//dependency_check:BUILD.dependency_check",
13+
build_file = "@rules_booking//booking/dependency_check:BUILD.dependency_check",
1414
)
File renamed without changes.
File renamed without changes.

module.bzl renamed to booking/module.bzl

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ This dependency is internal for rules_booking
55
"""
66

77
load("@bazel_tools//tools/build_defs/repo:http.bzl", "http_archive")
8-
load("//:repositories.bzl", "bazel_version")
8+
load("//booking:repositories.bzl", "bazel_version")
99

1010
def _extra_dependencies_impl(ctx):
1111
# OWASP Dependencies Check tool
@@ -18,7 +18,7 @@ def _extra_dependencies_impl(ctx):
1818
urls = [
1919
"https://github.com/jeremylong/DependencyCheck/releases/download/v8.4.3/dependency-check-8.4.3-release.zip",
2020
],
21-
build_file = "//dependency_check:BUILD.dependency_check",
21+
build_file = "//booking/dependency_check:BUILD.dependency_check",
2222
)
2323

2424
bazel_version(name = "bazel_version")

0 commit comments

Comments
 (0)