Merge pull request #221 from dannysauer/bug/no-require-terminal

creswick · web-flow · commit 0ab55f846d49 · 2023-06-20T16:04:05.000-07:00
Only emit terminal codes to terminal (and don't require `say`)
diff --git a/git-secrets b/git-secrets
@@ -205,7 +205,8 @@ install_hook() {
   echo "#!/usr/bin/env bash" > "${dest}"
   echo "git secrets --${cmd} -- \"\$@\"" >> "${dest}"
   chmod +x "${dest}"
-  say "$(tput setaf 2)✓$(tput sgr 0) Installed ${hook} hook to ${dest}"
+  [ -t 1 ] && command -v tput &> /dev/null && echo -n "$(tput setaf 2)✓$(tput sgr 0) "
+  echo "Installed ${hook} hook to ${dest}"
 }
 
 install_all_hooks() {

Original file line number	Diff line number	Diff line change
`@@ -205,7 +205,8 @@ install_hook() {`
`205`	`205`	`echo "#!/usr/bin/env bash" > "${dest}"`
`206`	`206`	`echo "git secrets --${cmd} -- \"\$@\"" >> "${dest}"`
`207`	`207`	`chmod +x "${dest}"`
`208`		`- say "$(tput setaf 2)✓$(tput sgr 0) Installed ${hook} hook to ${dest}"`
	`208`	`+ [ -t 1 ] && command -v tput &> /dev/null && echo -n "$(tput setaf 2)✓$(tput sgr 0) "`
	`209`	`+ echo "Installed ${hook} hook to ${dest}"`
`209`	`210`	`}`
`210`	`211`
`211`	`212`	`install_all_hooks() {`