From 7297610d53b6e0cd4ba87d63be3e4dcf3324580f Mon Sep 17 00:00:00 2001 From: Divya Raj Date: Wed, 25 Oct 2023 14:46:31 -0700 Subject: [PATCH 1/2] Stop logging event data --- src/resource.ts | 1 - 1 file changed, 1 deletion(-) diff --git a/src/resource.ts b/src/resource.ts index 7f81b7b..7992ccb 100644 --- a/src/resource.ts +++ b/src/resource.ts @@ -586,7 +586,6 @@ export abstract class BaseResource< this.prepareCredentialsFilter(this.callerSession) ); } - this.log('EVENT DATA\n', eventData); progress = await this.invokeHandler( this.callerSession, request, From 208bdc61a28b5ebc9accb5e1ca9d89bf7630c39f Mon Sep 17 00:00:00 2001 From: Divya Raj Date: Wed, 25 Oct 2023 17:25:59 -0700 Subject: [PATCH 2/2] Fix unit test --- tests/lib/resource.test.ts | 15 +-------------- 1 file changed, 1 insertion(+), 14 deletions(-) diff --git a/tests/lib/resource.test.ts b/tests/lib/resource.test.ts index a41d6e8..3c28ad1 100644 --- a/tests/lib/resource.test.ts +++ b/tests/lib/resource.test.ts @@ -249,7 +249,7 @@ describe('when getting resource', () => { }); test('entrypoint redacting credentials', async () => { - expect.assertions(13); + expect.assertions(5); const spyPublishLogEvent = jest.spyOn( LogPublisher.prototype, 'publishLogEvent' @@ -283,19 +283,6 @@ describe('when getting resource', () => { expect(spyPrepareLogStream).toBeCalledTimes(1); expect(spyPublishLogEvent).toHaveBeenCalled(); expect(mockPublishMessage).toHaveBeenCalled(); - mockPublishMessage.mock.calls.forEach((value: any[]) => { - const message = value[0] as string; - if (message && message.startsWith('EVENT DATA')) { - expect(message).toMatch(/bearerToken: ''/); - expect(message).toMatch( - /providerCredentials: {\s+accessKeyId: '',\s+secretAccessKey: '',\s+sessionToken: ''\s+}/ - ); - expect(message).toMatch( - /callerCredentials: {\s+accessKeyId: '',\s+secretAccessKey: '',\s+sessionToken: ''\s+}/ - ); - expect(message).toMatch(/stack\/sample-stack\//); - } - }); }); test('entrypoint with callback context', async () => {