no docker switch

Author: Michael Maeng

python/rpdk/typescript/codegen.py

@@ -72,12 +72,17 @@ def _init_from_project(self, project):
 
     def _init_settings(self, project):
         LOG.debug("Writing settings")
-        self._use_docker = self._use_docker or input_with_validation(
-            "Use docker for platform-independent packaging (Y/n)?\n",
-            validate_no,
-            "This is highly recommended unless you are experienced \n"
-            "with cross-platform Typescript packaging.",
-        )
+        if project.settings.get("use_docker") is True:
+            self._use_docker = True
+        elif project.settings.get("no_docker") is True:
+            self._use_docker = False
+        else:
+            self._use_docker = input_with_validation(
+                "Use docker for platform-independent packaging (Y/n)?\n",
+                validate_no,
+                "This is highly recommended unless you are experienced \n"
+                "with cross-platform Typescript packaging.",
+            )
         # switched to 'use_docker' from 'useDocker' to be in line with python version
         project.settings["use_docker"] = self._use_docker
         project.settings["protocolVersion"] = self._protocol_version

python/rpdk/typescript/parser.py

@@ -15,4 +15,11 @@ def setup_subparser(subparsers, parents):
             with cross-platform TypeScript packaging.""",
     )
 
+    parser.add_argument(
+        "--no-docker",
+        action="store_true",
+        help="""Generally not recommended unless you are experienced
+            with cross-platform Typescript packaging.""",
+    )
+
     return parser

tests/plugin/codegen_test.py

@@ -49,6 +49,8 @@ def project(tmp_path: str):
         lib_abspath = os.path.abspath(os.path.join(current_path, "..", "..", ".."))
         TypescriptLanguagePlugin.SUPPORT_LIB_URI = f"file:{lib_abspath}"
         project.init(TYPE_NAME, TypescriptLanguagePlugin.NAME)
+        project.settings["use_docker"] = False
+        project.settings["no_docker"] = False
     return project
 
 
@@ -94,7 +96,11 @@ def test__remove_build_artifacts_file_not_found(tmp_path: str):
 
 def test_initialize(project: Project):
     lib_path = project._plugin._lib_path
-    assert project.settings == {"use_docker": False, "protocolVersion": "2.0.0"}
+    assert project.settings == {
+        "protocolVersion": "2.0.0",
+        "no_docker": False,
+        "use_docker": False,
+    }
 
     files = get_files_in_project(project)
     assert set(files) == {

tests/plugin/parser_test.py

@@ -12,11 +12,19 @@ def test_setup_subparser():
     args = sub_parser.parse_args([])
     assert args.language == "typescript"
     assert args.use_docker is False
+    assert args.no_docker is False
 
     short_args = sub_parser.parse_args(["-d"])
     assert short_args.language == "typescript"
     assert short_args.use_docker is True
+    assert short_args.no_docker is False
 
     long_args = sub_parser.parse_args(["--use-docker"])
     assert long_args.language == "typescript"
     assert long_args.use_docker is True
+    assert long_args.no_docker is False
+
+    no_docker = sub_parser.parse_args(["--no-docker"])
+    assert no_docker.language == "typescript"
+    assert no_docker.use_docker is False
+    assert no_docker.no_docker is True