Skip to content

Commit ff548d8

Browse files
committed
fix: do not null set subs
1 parent 286a0f1 commit ff548d8

File tree

1 file changed

+2
-7
lines changed

1 file changed

+2
-7
lines changed

src/signature-help-manager.ts

Lines changed: 2 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -86,10 +86,7 @@ export class SignatureHelpManager {
8686
}
8787
this.editorSubscriptions = null
8888

89-
if (this.subscriptions) {
90-
this.subscriptions.dispose()
91-
}
92-
this.subscriptions = null
89+
this.subscriptions.dispose()
9390
}
9491

9592
/**
@@ -131,9 +128,7 @@ export class SignatureHelpManager {
131128

132129
return new Disposable(() => {
133130
disposable.dispose()
134-
if (this.subscriptions != null) {
135-
this.subscriptions.remove(disposable)
136-
}
131+
this.subscriptions.remove(disposable)
137132
this.watchedEditors.delete(editor)
138133
})
139134
}

0 commit comments

Comments
 (0)