Skip to content

Commit cf7eda5

Browse files
committed
perf: glow only the info bar
BREAKING remove glow on hover config
1 parent b0894ca commit cf7eda5

File tree

3 files changed

+8
-19
lines changed

3 files changed

+8
-19
lines changed

src/main.ts

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -37,11 +37,5 @@ export const config = {
3737
"If set to true, the signature help is shown as soon as you start typing. Otherwise you will have to activate it via keypress.",
3838
type: "boolean",
3939
default: true,
40-
},
41-
glowOnHover: {
42-
title: "Glow on hover",
43-
description: "Should signature glow when you hover on it?",
44-
type: "boolean",
45-
default: true,
46-
},
40+
}
4741
}

src/signature-help-manager.ts

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -38,9 +38,6 @@ export class SignatureHelpManager {
3838
*/
3939
showSignatureHelpOnTyping = false
4040

41-
// glow on hover class
42-
glowClass = atom.config.get("atom-ide-signature-help.glowOnHover") ? "signature-glow" : ""
43-
4441
/**
4542
* initialization routine
4643
*/
@@ -259,7 +256,7 @@ export class SignatureHelpManager {
259256
containerClassName: "signature-markdown-container",
260257
contentClassName: "signature-markdown",
261258
},
262-
className: `signature-element ${this.glowClass}`,
259+
className: "signature-element",
263260
})
264261
this.signatureHelpDisposables = this.mountSignatureHelp(editor, position, signatureHelpView)
265262
}

styles/atom-ide-signature-help.less

Lines changed: 6 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -44,17 +44,15 @@
4444
}
4545
}
4646

47-
.signature-glow {
48-
// glow on hover
49-
transition: background-color 0.15s ease;
50-
&:hover {
51-
background-color: mix(@syntax-background-color, @syntax-selection-color, 95%);
52-
}
53-
}
54-
5547
.signature-overlay {
5648
border-bottom: 5px solid @background-color-highlight;
5749
border-radius: 3px;
50+
51+
// info bar glow
52+
transition: border-bottom-color 0.15s ease;
53+
&:hover {
54+
border-bottom-color: lighten(@background-color-highlight, 10%);
55+
}
5856
}
5957

6058
.signature-content {

0 commit comments

Comments
 (0)