fix: keep react outside of the bundle

aminya · aminya · commit 4cf07aec5eaf · 2021-06-07T17:47:22.000-05:00
React is probably already cached with one of the other packages
diff --git a/rollup.config.js b/rollup.config.js
@@ -13,7 +13,7 @@ export default [
       },
     ],
     // loaded externally
-    external: ["atom"],
+    external: ["atom", "react", "react-dom"],
     plugins: plugins,
   },
 ]
diff --git a/src/tsconfig.json b/src/tsconfig.json
@@ -17,7 +17,6 @@
     "preserveSymlinks": true,
     "removeComments": true,
     "jsx": "react",
-    "jsxFactory": "etch.dom",
     "lib": ["ES2018", "dom"],
     "target": "ES2018",
     "allowJs": true,

Original file line number	Diff line number	Diff line change
`@@ -13,7 +13,7 @@ export default [`
`13`	`13`	`},`
`14`	`14`	`],`
`15`	`15`	`// loaded externally`
`16`		`- external: ["atom"],`
	`16`	`+ external: ["atom", "react", "react-dom"],`
`17`	`17`	`plugins: plugins,`
`18`	`18`	`},`
`19`	`19`	`]`