Skip to content

Commit f68f0d0

Browse files
authored
Merge pull request #58 from atom-community/selectable-text
2 parents cfe7c18 + 557cd24 commit f68f0d0

File tree

8 files changed

+288
-3024
lines changed

8 files changed

+288
-3024
lines changed

.github/workflows/CI.yml

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -23,11 +23,12 @@ jobs:
2323
channel: ${{ matrix.atom_channel }}
2424
- name: Versions
2525
run: apm -v
26-
- name: Install APM dependencies
26+
27+
- name: Install base dependencies
2728
run: |
2829
apm install
29-
- name: Atom Package dependencies
30-
run: node ./script/install-package-deps.js
30+
# ./node_modules/.bin/atom-package-deps ${{ github.workspace }}
31+
3132
# - name: Run tests 👩🏾‍💻
3233
# run: npm run test
3334

lib/main.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ module.exports = {
3131
if (!this.signatureHelpManager) this.signatureHelpManager = new SignatureHelpManager()
3232
this.subscriptions.add(this.signatureHelpManager)
3333
require("atom-package-deps")
34-
.install("atom-ide-signature-help")
34+
.install("atom-ide-signature-help", true)
3535
.then(() => {
3636
this.signatureHelpManager.initialize(this.renderer)
3737
})

lib/signature-help-manager.js

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@
55
const { CompositeDisposable, Disposable, Range, Point, TextEditor } = require("atom")
66
import { ProviderRegistry } from "atom-ide-base/commons-atom/ProviderRegistry"
77
import { ViewContainer } from "atom-ide-base/commons-ui/float-pane/ViewContainer"
8+
import { makeOverlaySelectable, makeOverLayCopyable } from "atom-ide-base/commons-ui/float-pane/selectable-overlay"
89

910
module.exports = class SignatureHelpManager {
1011
constructor() {
@@ -294,6 +295,9 @@ module.exports = class SignatureHelpManager {
294295
invalidate: "overlap", // TODO It was never. Shouldn't be surround?
295296
})
296297

298+
makeOverlaySelectable(editor, view.element)
299+
makeOverLayCopyable(view.element)
300+
297301
const marker = editor.decorateMarker(overlayMarker, {
298302
type: "overlay",
299303
class: "signature-overlay",

0 commit comments

Comments
 (0)