Skip to content

Commit 15a5bf4

Browse files
committed
fix: documentation can be null
1 parent dc34c63 commit 15a5bf4

File tree

2 files changed

+4
-3
lines changed

2 files changed

+4
-3
lines changed

rollup.config.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ export default [
99
{
1010
dir: "dist",
1111
format: "cjs",
12-
sourcemap: true,
12+
sourcemap: process.env.NODE_ENV === "production" ? true : "inline",
1313
},
1414
],
1515
// loaded externally

src/signature-help-manager.ts

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -220,7 +220,8 @@ export class SignatureHelpManager {
220220
let doc = ""
221221
if (parameter) {
222222
let parameterDocumentation = ""
223-
if (parameter.documentation === undefined) {
223+
// TODO documentation can be null. Update the types!
224+
if (parameter.documentation === undefined || parameter.documentation === null) {
224225
// parameterDocumentation = ""
225226
} else if (typeof parameter.documentation === "string") {
226227
parameterDocumentation = parameter.documentation
@@ -231,7 +232,7 @@ export class SignatureHelpManager {
231232
doc = `<b>${parameter.label}</b> ${parameterDocumentation}`
232233
} else if (signature.documentation) {
233234
let signatureDocumentation = ""
234-
if (signature.documentation === undefined) {
235+
if (signature.documentation === undefined || signature.documentation === null) {
235236
// signatureDocumentation = ""
236237
} else if (typeof signature.documentation === "string") {
237238
signatureDocumentation = signature.documentation

0 commit comments

Comments
 (0)