fix failing test

Author: AlexWaygood

crates/ty_ide/src/completion.rs

@@ -1849,7 +1849,7 @@ def test_point(p2: Point):
         );
 
         let completions = test.completions();
-        assert_eq!(completions, "orthogonal_direction");
+        test.assert_completions_include("orthogonal_direction");
     }
 
     impl CursorTest {

crates/ty_python_semantic/src/semantic_index/builder.rs

@@ -33,7 +33,7 @@ use crate::semantic_index::definition::{
 use crate::semantic_index::expression::{Expression, ExpressionKind};
 use crate::semantic_index::place::{
     FileScopeId, NodeWithScopeKey, NodeWithScopeKind, NodeWithScopeRef, PlaceExpr,
-    PlaceTableBuilder, Scope, ScopeId, ScopeKind, ScopedPlaceId,
+    PlaceExprSubSegment, PlaceTableBuilder, Scope, ScopeId, ScopeKind, ScopedPlaceId,
 };
 use crate::semantic_index::predicate::{
     PatternPredicate, PatternPredicateKind, Predicate, PredicateNode, ScopedPredicateId,
@@ -1964,12 +1964,14 @@ impl<'ast> Visitor<'ast> for SemanticIndexBuilder<'_, 'ast> {
             | ast::Expr::Attribute(ast::ExprAttribute { ctx, .. })
             | ast::Expr::Subscript(ast::ExprSubscript { ctx, .. }) => {
                 if let Ok(mut place_expr) = PlaceExpr::try_from(expr) {
-                    if self.is_method_of_class().is_some() {
+                    if self.is_method_of_class().is_some()
+                        && matches!(place_expr.sub_segments(), &[PlaceExprSubSegment::Member(_)])
+                    {
                         // We specifically mark attribute assignments to the first parameter of a method,
                         // i.e. typically `self` or `cls`.
                         let accessed_object_refers_to_first_parameter = self
                             .current_first_parameter_name
-                            .is_some_and(|fst| place_expr.root_name().as_str() == fst);
+                            .is_some_and(|fst| place_expr.root_name() == fst);
 
                         if accessed_object_refers_to_first_parameter && place_expr.is_member() {
                             place_expr.mark_instance_attribute();

crates/ty_python_semantic/src/types/ide_support.rs

@@ -186,7 +186,9 @@ impl AllMembers {
             for function_scope_id in attribute_scopes(db, class_body_scope) {
                 let place_table = index.place_table(function_scope_id);
                 for instance_attribute in place_table.instance_attributes() {
-                    let name = instance_attribute.sub_segments()[0].as_member().unwrap();
+                    let name = instance_attribute.sub_segments()[0]
+                        .as_member()
+                        .expect("Non-members should never be registered as instance attributes");
                     self.members.insert(name.clone());
                 }
             }