Fix: MSVC compilation warnings

Author: ashvardanian

c/lib.cpp

@@ -150,7 +150,7 @@ size_t fu_count_quality_levels(void) {
 
 size_t fu_volume_any_pages(void) { return fu::get_ram_total_volume(); }
 
-size_t fu_volume_huge_pages_in(size_t numa_node_index) {
+size_t fu_volume_huge_pages_in(FU_MAYBE_UNUSED_ size_t numa_node_index) {
 #if FU_ENABLE_NUMA
     size_t total_volume = 0;
     auto const &node = global_numa_topology.node(numa_node_index);
@@ -161,7 +161,7 @@ size_t fu_volume_huge_pages_in(size_t numa_node_index) {
 #endif
 }
 
-size_t fu_volume_any_pages_in(size_t numa_node_index) {
+size_t fu_volume_any_pages_in(FU_MAYBE_UNUSED_ size_t numa_node_index) {
 #if FU_ENABLE_NUMA
     if (!globals_initialize()) return 0;
     if (numa_node_index >= global_numa_topology.nodes_count()) return 0;
@@ -177,8 +177,8 @@ size_t fu_volume_any_pages_in(size_t numa_node_index) {
 
 #pragma region - Memory
 
-void *fu_allocate_at_least(                       //
-    size_t numa_node_index, size_t minimum_bytes, //
+void *fu_allocate_at_least(                                        //
+    FU_MAYBE_UNUSED_ size_t numa_node_index, size_t minimum_bytes, //
     size_t *allocated_bytes, size_t *bytes_per_page) {
 
 #if FU_ENABLE_NUMA
@@ -198,7 +198,7 @@ void *fu_allocate_at_least(                       //
 #endif
 }
 
-void *fu_allocate(size_t numa_node_index, size_t bytes) {
+void *fu_allocate(FU_MAYBE_UNUSED_ size_t numa_node_index, size_t bytes) {
 
 #if FU_ENABLE_NUMA
     auto const &node = global_numa_topology.node(numa_node_index);
@@ -209,7 +209,7 @@ void *fu_allocate(size_t numa_node_index, size_t bytes) {
 #endif
 }
 
-void fu_free(size_t numa_node_index, void *pointer, size_t bytes) {
+void fu_free(FU_MAYBE_UNUSED_ size_t numa_node_index, void *pointer, FU_MAYBE_UNUSED_ size_t bytes) {
 #if FU_ENABLE_NUMA
     auto const &node = global_numa_topology.node(numa_node_index);
     fu::linux_numa_allocator_t allocator(node.node_id);
@@ -223,7 +223,7 @@ void fu_free(size_t numa_node_index, void *pointer, size_t bytes) {
 
 #pragma region - Lifetime
 
-fu_pool_t *fu_pool_new(char const *name) {
+fu_pool_t *fu_pool_new(FU_MAYBE_UNUSED_ char const *name) {
     if (!globals_initialize()) return nullptr;
 
     opaque_pool_t *opaque = static_cast<opaque_pool_t *>(std::malloc(sizeof(opaque_pool_t)));

include/fork_union.hpp

@@ -146,7 +146,7 @@
 #if defined(__GNUC__) || defined(__clang__)
 #define FU_MAYBE_UNUSED_ __attribute__((unused))
 #elif defined(_MSC_VER)
-#define FU_MAYBE_UNUSED_ __pragma(warning(suppress : 4100))
+#define FU_MAYBE_UNUSED_ __pragma(warning(suppress : 4100 4189))
 #else
 #define FU_MAYBE_UNUSED_
 #endif
@@ -3679,10 +3679,15 @@ struct logging_colors_t {
 #if defined(__unix__) || defined(__APPLE__)
         if (!::isatty(STDOUT_FILENO)) return;
 #endif
+#if defined(_WIN32)
+        // On Windows, assume color support is available
+        use_colors_ = true;
+#else
         char const *term = std::getenv("TERM");
         if (!term) return;
         use_colors_ = std::strstr(term, "color") != nullptr || std::strstr(term, "xterm") != nullptr ||
                       std::strstr(term, "screen") != nullptr || std::strcmp(term, "linux") == 0;
+#endif
     }
 
     /* ANSI style codes */

scripts/nbody.cpp

@@ -114,7 +114,8 @@ inline void apply_force(body_t &bi, vector3_t const &f) noexcept {
 
 #pragma region - Backends
 
-void iteration_openmp_static(body_t *_FU_RESTRICT bodies, vector3_t *_FU_RESTRICT forces, std::size_t n) noexcept {
+void iteration_openmp_static(FU_MAYBE_UNUSED_ body_t *_FU_RESTRICT bodies,
+                             FU_MAYBE_UNUSED_ vector3_t *_FU_RESTRICT forces, FU_MAYBE_UNUSED_ std::size_t n) noexcept {
 #if defined(_OPENMP)
 #pragma omp parallel for schedule(static)
     for (std::size_t i = 0; i < n; ++i) {
@@ -127,7 +128,9 @@ void iteration_openmp_static(body_t *_FU_RESTRICT bodies, vector3_t *_FU_RESTRIC
 #endif
 }
 
-void iteration_openmp_dynamic(body_t *_FU_RESTRICT bodies, vector3_t *_FU_RESTRICT forces, std::size_t n) noexcept {
+void iteration_openmp_dynamic(FU_MAYBE_UNUSED_ body_t *_FU_RESTRICT bodies,
+                              FU_MAYBE_UNUSED_ vector3_t *_FU_RESTRICT forces,
+                              FU_MAYBE_UNUSED_ std::size_t n) noexcept {
 #if defined(_OPENMP)
 #pragma omp parallel for schedule(dynamic, 1)
     for (std::size_t i = 0; i < n; ++i) {
@@ -258,11 +261,23 @@ void iteration_fork_union_numa_dynamic(linux_distributed_pool_t &pool, body_t *_
 int main(void) {
     std::printf("Welcome to the Fork Union N-Body simulation!\n");
 
+    // Helper function to safely get environment variables
+    auto safe_getenv = [](char const *name) -> char const * {
+#if defined(_MSC_VER)
+        static thread_local char buffer[256];
+        size_t required_size;
+        errno_t err = getenv_s(&required_size, buffer, sizeof(buffer), name);
+        return (err == 0 && required_size > 0) ? buffer : nullptr;
+#else
+        return std::getenv(name); // ! Windows doesn't like this
+#endif
+    };
+
     // Read env vars
-    auto const n_str = std::getenv("NBODY_COUNT");
-    auto const iterations_str = std::getenv("NBODY_ITERATIONS");
-    auto const backend_str = std::getenv("NBODY_BACKEND");
-    auto const threads_str = std::getenv("NBODY_THREADS");
+    auto const n_str = safe_getenv("NBODY_COUNT");
+    auto const iterations_str = safe_getenv("NBODY_ITERATIONS");
+    auto const backend_str = safe_getenv("NBODY_BACKEND");
+    auto const threads_str = safe_getenv("NBODY_THREADS");
 
     // Parse env vars and validate
     std::size_t n = std::strtoull(n_str ? n_str : "0", nullptr, 10);