Skip to content

Helm urlquery function breaks the placeholder if used #701

@sea-gull-diana

Description

@sea-gull-diana

Some Helm charts make use of urlquery function to encode the value in order to include it in URLs. For example, Harbor helm chart does it with redis password if you pass it in values file for an external redis connection (value redis.external.password).

Using an avp placeholder for redis password results in content like this in generated ConfigMaps:

_REDIS_URL_CORE: >-     redis://:%3Cpath%3Akv%2Fdata%2Fkube%2Fconfig%2Fharbor%2Fredis-pwd%23password%[email protected]/0?idle_timeout_seconds=30
_REDIS_URL_REG: >-     redis://:%3Cpath%3Akv%2Fdata%2Fkube%2Fconfig%2Fharbor%2Fredis-pwd%23password%[email protected]/2?idle_timeout_seconds=30

I know the plugin can recognize base64-encoded placeholders, it isn't hard to make it also recognize url-encoded ones. I'm going to make a pull request for this. Hope this repo will return to life at some point, I use this plugin a lot :)

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions