feat: Add Redis server address as ConfigMap param for agent and principal (#508)

Signed-off-by: navin <[email protected]>
Signed-off-by: navin <[email protected]>
Co-authored-by: navin <[email protected]>

Author: ncr38

docs/configuration/agent/configuration.md

@@ -217,7 +217,7 @@ The recommended approach for production deployments is to use ConfigMap entries
 #### Redis Address
 - **Command Line Flag**: `--redis-addr`
 - **Environment Variable**: `REDIS_ADDR`
-- **ConfigMap Entry**: *(Not available in ConfigMap)*
+- **ConfigMap Entry**: `agent.redis.address`
 - **Description**: The redis host to connect to
 - **Type**: String
 - **Default**: `"argocd-redis:6379"`

docs/configuration/principal/configuration.md

@@ -341,7 +341,7 @@ The recommended approach for production deployments is to use ConfigMap entries
 #### Redis Server Address
 - **Command Line Flag**: `--redis-server-address`
 - **Environment Variable**: `ARGOCD_PRINCIPAL_REDIS_SERVER_ADDRESS`
-- **ConfigMap Entry**: *(Not available in ConfigMap)*
+- **ConfigMap Entry**: `principal.redis.server.address`
 - **Description**: Redis server hostname and port
 - **Type**: String
 - **Default**: `"argocd-redis:6379"`

install/helm-repo/argocd-agent-agent/templates/agent-deployment.yaml

@@ -108,6 +108,12 @@ spec:
                 name: argocd-agent-params
                 key: agent.healthz.port
                 optional: true
+          - name: REDIS_ADDR
+            valueFrom:
+              configMapKeyRef:
+                name: argocd-agent-params
+                key: agent.redis.address
+                optional: true
           name: argocd-agent-agent
           imagePullPolicy: Always
           image: "{{ .Values.image }}:{{ .Values.imageTag }}"

install/helm-repo/argocd-agent-agent/templates/agent-params-cm.yaml

@@ -56,4 +56,7 @@ data:
   agent.metrics.port: {{ .Values.metricsPort | quote }}
   # agent.healthz.port: The port the health check server should listen on.
   # Default: 8002
-  agent.healthz.port: {{ .Values.healthzPort | quote }}
+  agent.healthz.port: {{ .Values.healthzPort | quote }}
+  # agent.redis.address: The address of the Redis server.
+  # Default: "argocd-redis:6379"
+  agent.redis.address: {{ .Values.redisAddress | quote }}

install/helm-repo/argocd-agent-agent/templates/tests/test-configMap.yaml

@@ -118,6 +118,15 @@ spec:
           echo "✗ agent.healthz.port missing"
           exit 1
         fi
+
+        # Test  agent.redis.address
+        if [ -f /etc/config/agent.redis.address ]; then
+          echo "✓ agent.redis.address exists"
+          cat /etc/config/agent.redis.address
+        else
+          echo "✗ agent.redis.address missing"
+          exit 1
+        fi
 
         echo "All ConfigMap keys verified successfully!"
       ']

install/helm-repo/argocd-agent-agent/values.yaml

@@ -20,6 +20,7 @@ serverPort: "443"
 metricsPort: "8181"
 tlsClientInSecure: "false"
 healthzPort: "8002"
+redisAddress: "argocd-redis:6379"
 tlsClientKeyPath: "/app/config/tls/tls.key"
 tlsClientCertPath: "/app/config/tls/tls.crt"
 tlsRootCAPath: "/app/config/tls/ca.crt"

install/kubernetes/agent/agent-deployment.yaml

@@ -135,6 +135,12 @@ spec:
                 name: argocd-agent-params
                 key: agent.pprof.port
                 optional: true
+          - name: REDIS_ADDR
+            valueFrom:
+              configMapKeyRef:
+                name: argocd-agent-params
+                key: agent.redis.address
+                optional: true
           - name: REDIS_PASSWORD
             valueFrom:
               secretKeyRef:

install/kubernetes/agent/agent-params-cm.yaml

@@ -82,4 +82,7 @@ data:
   agent.pprof.port: "0"
   # agent.resource-proxy.enable: Whether to enable the resource proxy.
   # Default: true
-  agent.resource-proxy.enable: "true"
+  agent.resource-proxy.enable: "true"
+  # agent.redis.address: The address of the Redis server.
+  # Default: "argocd-redis:6379"
+  agent.redis.address: "argocd-redis:6379"

install/kubernetes/principal/principal-deployment.yaml

@@ -201,6 +201,12 @@ spec:
                 name: argocd-agent-params
                 key: principal.redis.compression.type
                 optional: true
+          - name: ARGOCD_PRINCIPAL_REDIS_SERVER_ADDRESS
+            valueFrom:
+              configMapKeyRef:
+                name: argocd-agent-params
+                key: principal.redis.server.address
+                optional: true
           - name: ARGOCD_PRINCIPAL_ENABLE_RESOURCE_PROXY
             valueFrom:
               configMapKeyRef:

install/kubernetes/principal/principal-params-cm.yaml

@@ -137,3 +137,6 @@ data:
   # principal.pprof.port: The port the pprof server will listen on.
   # Default: 0
   principal.pprof.port: "0"
+  # principal.redis.server.address: The address of the Redis server.
+  # Default: "argocd-redis:6379"
+  principal.redis.server.address: "argocd-redis:6379"