video player: use square BO

When uploading memory with size X into a dmabuf, create a buffer that is square
(e.g. sqrt(x) by sqrt(x)) instead of one that is X pixels wide and one pixel
high.

Drivers have limitations on buffer dimensions, and e.g. the intel (iris) driver
ran into this limitation.

Author: ardera

src/plugins/gstreamer_video_player/frame.c

@@ -359,14 +359,18 @@ UNUSED int dup_gst_buffer_range_as_dmabuf(struct gbm_device *gbm_device, GstBuff
         return -1;
     }
 
-    bo = gbm_bo_create(gbm_device, map_info.size, 1, GBM_FORMAT_R8, GBM_BO_USE_LINEAR);
+// Create a square texture large enough to fit our bytes instead of one with only one huge row,
+    // because some drivers have limitations on the row length. (Intel)
+    uint32_t dim = (uint32_t) ceil(sqrt(map_info.size));
+
+    bo = gbm_bo_create(gbm_device, dim, dim, GBM_FORMAT_R8, GBM_BO_USE_LINEAR);
     if (bo == NULL) {
         LOG_ERROR("Couldn't create GBM BO to copy video frame into.\n");
         goto fail_unmap_buffer;
     }
 
     map_data = NULL;
-    map = gbm_bo_map(bo, 0, 0, map_info.size, 1, GBM_BO_TRANSFER_WRITE, &stride, &map_data);
+    map = gbm_bo_map(bo, 0, 0, dim, dim, GBM_BO_TRANSFER_WRITE, &stride, &map_data);
     if (map == NULL) {
         LOG_ERROR("Couldn't mmap GBM BO to copy video frame into it.\n");
         goto fail_destroy_bo;
@@ -415,14 +419,18 @@ UNUSED int dup_gst_memory_as_dmabuf(struct gbm_device *gbm_device, GstMemory *me
         return -1;
     }
 
-    bo = gbm_bo_create(gbm_device, map_info.size, 1, GBM_FORMAT_R8, GBM_BO_USE_LINEAR);
+// Create a square texture large enough to fit our bytes instead of one with only one huge row,
+    // because some drivers have limitations on the row length. (Intel)
+    uint32_t dim = (uint32_t) ceil(sqrt(map_info.size));
+
+    bo = gbm_bo_create(gbm_device, dim, dim, GBM_FORMAT_R8, GBM_BO_USE_LINEAR);
     if (bo == NULL) {
         LOG_ERROR("Couldn't create GBM BO to copy video frame into.\n");
         goto fail_unmap_buffer;
     }
 
     map_data = NULL;
-    map = gbm_bo_map(bo, 0, 0, map_info.size, 1, GBM_BO_TRANSFER_WRITE, &stride, &map_data);
+    map = gbm_bo_map(bo, 0, 0, dim, dim, GBM_BO_TRANSFER_WRITE, &stride, &map_data);
     if (map == NULL) {
         LOG_ERROR("Couldn't mmap GBM BO to copy video frame into it.\n");
         goto fail_destroy_bo;