fix(engine):disable feedback

commit: 77d211e (main), cherry-pick

Author: NDStrahilevitz

pkg/signatures/engine/engine.go

@@ -5,7 +5,6 @@ import (
 	"fmt"
 	"sync"
 
-	"github.com/aquasecurity/tracee/pkg/events/findings"
 	"github.com/aquasecurity/tracee/pkg/logger"
 	"github.com/aquasecurity/tracee/pkg/signatures/metrics"
 	"github.com/aquasecurity/tracee/types/detect"
@@ -147,17 +146,23 @@ func (engine *Engine) unloadAllSignatures() {
 func (engine *Engine) matchHandler(res *detect.Finding) {
 	_ = engine.stats.Detections.Increment()
 	engine.output <- res
-	if !engine.config.Enabled {
-		return
-		// next section is relevant only for engine-in-pipeline and analyze
-	}
-	e, err := findings.FindingToEvent(res)
-	if err != nil {
-		logger.Errorw("Failed to convert finding to event, will not feedback", "err", err)
-		return
-	}
-	prot := e.ToProtocol()
-	engine.inputs.Tracee <- prot
+	// TODO: the feedback is disabled for now, as it was causing a deadlock
+	//       when the engine was blocked on sending a new event to the feedbacking signature.
+	//       This is because the engine would eventually block on trying to to send
+	//       a new event to the feedbacking signature. This would cause a deadlock
+	//       there - propagating back to the engine and pipeline in general.
+	//       We should keep it here for reference until we find a better solution.
+	// if !engine.config.Enabled {
+	// 	return
+	// 	// next section is relevant only for engine-in-pipeline and analyze
+	// }
+	// e, err := findings.FindingToEvent(res)
+	// if err != nil {
+	// 	logger.Errorw("Failed to convert finding to event, will not feedback", "err", err)
+	// 	return
+	// }
+	// prot := e.ToProtocol()
+	// engine.inputs.Tracee <- prot
 }
 
 // checkCompletion is a function that runs at the end of each input source