Fix ambiguous conditions (#1373)

MuhammadTahaNaveed · web-flow · commit 4817f8a049ad · 2023-11-07T10:44:07.000-08:00
- These conditions were ambiguous for compiler as well as for other
  devs.
diff --git a/src/backend/utils/adt/agtype_ops.c b/src/backend/utils/adt/agtype_ops.c
@@ -1277,7 +1277,7 @@ Datum agtype_exists_agtype(PG_FUNCTION_ARGS)
                                              aval);
     }
     else if (AGT_ROOT_IS_ARRAY(agt) &&
-             !aval->type == AGTV_NULL)
+             aval->type != AGTV_NULL)
     {
         v = find_agtype_value_from_container(&agt->root,
                                              AGT_FARRAY,
@@ -1319,7 +1319,7 @@ Datum agtype_exists_any_agtype(PG_FUNCTION_ARGS)
                     PG_RETURN_BOOL(true);
                 }
                 else if (AGT_ROOT_IS_ARRAY(agt) &&
-                         !(&elem)->type == AGTV_NULL &&
+                         (&elem)->type != AGTV_NULL &&
                          find_agtype_value_from_container(&agt->root,
                                                            AGT_FARRAY,
                                                            &elem))

Original file line number	Diff line number	Diff line change
`@@ -1277,7 +1277,7 @@ Datum agtype_exists_agtype(PG_FUNCTION_ARGS)`
`1277`	`1277`	`aval);`
`1278`	`1278`	`}`
`1279`	`1279`	`else if (AGT_ROOT_IS_ARRAY(agt) &&`
`1280`		`- !aval->type == AGTV_NULL)`
	`1280`	`+ aval->type != AGTV_NULL)`
`1281`	`1281`	`{`
`1282`	`1282`	`v = find_agtype_value_from_container(&agt->root,`
`1283`	`1283`	`AGT_FARRAY,`
`@@ -1319,7 +1319,7 @@ Datum agtype_exists_any_agtype(PG_FUNCTION_ARGS)`
`1319`	`1319`	`PG_RETURN_BOOL(true);`
`1320`	`1320`	`}`
`1321`	`1321`	`else if (AGT_ROOT_IS_ARRAY(agt) &&`
`1322`		`- !(&elem)->type == AGTV_NULL &&`
	`1322`	`+ (&elem)->type != AGTV_NULL &&`
`1323`	`1323`	`find_agtype_value_from_container(&agt->root,`
`1324`	`1324`	`AGT_FARRAY,`
`1325`	`1325`	`&elem))`