Skip to content
This repository was archived by the owner on Nov 8, 2023. It is now read-only.

Commit 25ad053

Browse files
TreeHugger RobotAndroid (Google) Code Review
authored andcommitted
Merge "Correct setting the RemoteView's provider id." into sc-dev
2 parents 6eb3589 + f8960a0 commit 25ad053

File tree

1 file changed

+2
-3
lines changed

1 file changed

+2
-3
lines changed

services/appwidget/java/com/android/server/appwidget/AppWidgetServiceImpl.java

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1839,8 +1839,6 @@ private void updateAppWidgetInstanceLocked(Widget widget, RemoteViews views,
18391839
// For a full update we replace the RemoteViews completely.
18401840
widget.views = views;
18411841
}
1842-
widget.views.setProviderInstanceId(UPDATE_COUNTER.get());
1843-
18441842
int memoryUsage;
18451843
if ((UserHandle.getAppId(Binder.getCallingUid()) != Process.SYSTEM_UID) &&
18461844
(widget.views != null) &&
@@ -1942,13 +1940,14 @@ private void scheduleNotifyUpdateAppWidgetLocked(Widget widget, RemoteViews upda
19421940
return;
19431941
}
19441942
if (updateViews != null) {
1943+
updateViews = new RemoteViews(updateViews);
19451944
updateViews.setProviderInstanceId(requestId);
19461945
}
19471946

19481947
SomeArgs args = SomeArgs.obtain();
19491948
args.arg1 = widget.host;
19501949
args.arg2 = widget.host.callbacks;
1951-
args.arg3 = (updateViews != null) ? updateViews.clone() : null;
1950+
args.arg3 = updateViews;
19521951
args.arg4 = requestId;
19531952
args.argi1 = widget.appWidgetId;
19541953

0 commit comments

Comments
 (0)