Merge pull request #10622 from alphagov/NAV-18198-retire-preview-url-from-attachments

Retire preview_url from attachments

Author: catalinailie

app/models/file_attachment.rb

@@ -52,7 +52,6 @@ def publishing_api_details_for_format
       file_size:,
       filename:,
       number_of_pages:,
-      preview_url:,
       assets:,
     }
   end
@@ -75,10 +74,4 @@ def assets
       }
     end
   end
-
-  def preview_url
-    return unless csv? && attachable.is_a?(Edition) && attachment_data.all_asset_variants_uploaded?
-
-    Plek.asset_root + "/media/#{attachment_data.id}/#{filename}/preview"
-  end
 end

test/unit/app/models/file_attachment_test.rb

@@ -64,11 +64,6 @@ def assert_delegated(attachment, method)
     assert attachment.filename_changed?
   end
 
-  test "return media preview_url if all_asset_variants_uploaded?" do
-    attachment = create(:csv_attachment, attachable: create(:edition))
-    assert_equal Plek.asset_root + "/media/#{attachment.attachment_data.id}/sample.csv/preview", attachment.publishing_api_details_for_format[:preview_url]
-  end
-
   test "#assets returns assets list if all_asset_variants_uploaded?" do
     attachment = create(:csv_attachment, attachable: create(:edition))
 

test/unit/app/presenters/publishing_api/publication_presenter_test.rb

@@ -289,6 +289,6 @@ def present(edition)
 
     attachments = presented_publication.content[:details][:attachments]
     assert_equal 1, attachments.length
-    assert_not_nil attachments[0][:preview_url]
+    assert_not_nil attachments[0][:assets]
   end
 end