Skip to content

Commit d28a5ca

Browse files
committed
Update dependency versions
1 parent 5db3b61 commit d28a5ca

File tree

7 files changed

+19
-81
lines changed

7 files changed

+19
-81
lines changed

build.gradle

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -43,6 +43,7 @@ allprojects {
4343

4444
subprojects { project ->
4545
apply from: "$rootDir/detekt.gradle"
46+
4647
afterEvaluate {
4748
tasks.withType(KotlinCompile).configureEach { task ->
4849
kotlinOptions {

detekt.yml

Lines changed: 8 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -97,7 +97,7 @@ complexity:
9797
active: false
9898
threshold: 10
9999
includeStaticDeclarations: false
100-
ComplexMethod:
100+
CyclomaticComplexMethod:
101101
active: false
102102
threshold: 20
103103
ignoreSingleWhenExpression: false
@@ -273,8 +273,7 @@ performance:
273273

274274
potential-bugs:
275275
active: true
276-
DuplicateCaseInWhenExpression:
277-
active: true
276+
# DuplicateCaseInWhenExpression is deprecated as compiler performs this check by default
278277
EqualsAlwaysReturnsTrueOrFalse:
279278
active: true
280279
EqualsWithHashCodeExist:
@@ -311,7 +310,7 @@ style:
311310
active: true
312311
DataClassContainsFunctions:
313312
active: false
314-
conversionFunctionPrefix: 'to'
313+
conversionFunctionPrefix: ['to']
315314
DestructuringDeclarationWithTooManyEntries:
316315
active: false
317316
EqualsNullCall:
@@ -320,14 +319,14 @@ style:
320319
active: false
321320
ForbiddenComment:
322321
active: false
323-
values: ['TODO:', 'FIXME:', 'STOPSHIP:']
322+
comments: ['TODO:', 'FIXME:', 'STOPSHIP:']
324323
ForbiddenImport:
325324
active: false
326325
imports: []
327326
FunctionOnlyReturningConstant:
328327
active: true
329328
ignoreOverridableFunction: true
330-
excludedFunctions: 'describeContents'
329+
excludedFunctions: ['describeContents']
331330
LoopWithTooManyJumpStatements:
332331
active: true
333332
maxJumpCount: 3
@@ -341,7 +340,7 @@ style:
341340
ignoreAnnotation: false
342341
ignoreNamedArgument: true
343342
ignoreEnums: false
344-
MandatoryBracesIfStatements:
343+
BracesOnIfStatements:
345344
active: false # TODO: consider this
346345
MaxLineLength:
347346
excludes: ['**/test/**', '.*Test.kt']
@@ -364,7 +363,7 @@ style:
364363
active: true
365364
OptionalUnit:
366365
active: false
367-
OptionalWhenBraces:
366+
BracesOnWhenStatements:
368367
active: false
369368
PreferToOverPairSyntax:
370369
active: true
@@ -375,7 +374,7 @@ style:
375374
ReturnCount:
376375
active: false
377376
max: 2
378-
excludedFunctions: "equals"
377+
excludedFunctions: ["equals"]
379378
SafeCast:
380379
active: true
381380
SerialVersionUIDInSerializableClass:

gradle/jacoco.gradle

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ configure(coveredProjects) { prj ->
88
apply plugin: 'jacoco'
99

1010
jacoco {
11-
toolVersion = "0.8.7"
11+
toolVersion = "0.8.11"
1212
}
1313

1414
task jacocoReport(type: JacocoReport, dependsOn: 'testDebugUnitTest') {

mvrx-common/src/main/java/com/airbnb/mvrx/MavericksMutabilityHelper.kt

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,8 +8,6 @@ import kotlin.reflect.KClass
88

99
private const val IMMUTABLE_LIST_MESSAGE =
1010
"Use the immutable listOf(...) method instead. You can append it with `val newList = listA + listB`"
11-
private const val IMMUTABLE_MAP_MESSAGE =
12-
"Use the immutable mapOf(...) method instead. You can append it with `val newMap = mapA + mapB`"
1311

1412
/**
1513
* Ensures that the state class is immutable.

mvrx-common/src/main/java/com/airbnb/mvrx/MavericksRepository.kt

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -53,8 +53,6 @@ abstract class MavericksRepository<S : MavericksState>(
5353
@InternalMavericksApi
5454
protected val stateStore: MavericksStateStore<S> = config.stateStore
5555

56-
private val tag by lazy { javaClass.simpleName }
57-
5856
private val mutableStateChecker = if (config.performCorrectnessValidations) MutableStateChecker(config.stateStore.state) else null
5957

6058
/**

sample-todo/src/main/java/com/airbnb/mvrx/todomvrx/util/SimpleCountingIdlingResource.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@ class SimpleCountingIdlingResource(private val resourceName: String) : IdlingRes
4949
// we've gone from non-zero to zero. That means we're idle now! Tell espresso.
5050
resourceCallback?.onTransitionToIdle()
5151
} else if (counterVal < 0) {
52-
throw IllegalArgumentException("Counter has been corrupted!")
52+
error("Counter has been corrupted!")
5353
}
5454
}
5555
}

versions.properties

Lines changed: 8 additions & 66 deletions
Original file line numberDiff line numberDiff line change
@@ -11,21 +11,7 @@ version.rxjava2.rxjava=2.2.21
1111

1212
version.rxjava2.rxandroid=2.1.1
1313

14-
version.robolectric=4.8.1
15-
## # available=4.8.2
16-
## # available=4.9-alpha-1
17-
## # available=4.9
18-
## # available=4.9.1
19-
## # available=4.9.2
20-
## # available=4.10-alpha-1
21-
## # available=4.10
22-
## # available=4.10.1
23-
## # available=4.10.2
24-
## # available=4.10.3
25-
## # available=4.11-beta-1
26-
## # available=4.11-beta-2
27-
## # available=4.11
28-
## # available=4.11.1
14+
version.robolectric=4.10.3
2915

3016
version.retrofit2=2.9.0
3117
## # available=2.10.0
@@ -116,7 +102,7 @@ version.kotlinx.coroutines=1.6.4
116102
## # available=1.8.0
117103
## # available=1.8.1-Beta
118104

119-
version.kotlin=1.8.22
105+
version.kotlin=1.9.22
120106
## # available=1.9.0-Beta
121107
## # available=1.9.0-RC
122108
## # available=1.9.0
@@ -191,39 +177,9 @@ version.io.gitlab.arturbosch.detekt..detekt-formatting=1.21.0
191177
## # available=1.23.5
192178
## # available=1.23.6
193179

194-
version.google.dagger=2.43.2
195-
## # available=2.44
196-
## # available=2.44.1
197-
## # available=2.44.2
198-
## # available=2.45
199-
## # available=2.46
200-
## # available=2.46.1
201-
## # available=2.47
202-
## # available=2.48
203-
## # available=2.48.1
204-
## # available=2.49
205-
## # available=2.50
206-
## # available=2.51
207-
208-
version.com.vanniktech..gradle-maven-publish-plugin=0.22.0
209-
## # available=0.23.0
210-
## # available=0.23.1
211-
## # available=0.23.2
212-
## # available=0.24.0
213-
## # available=0.25.0-rc1
214-
## # available=0.25.0
215-
## # available=0.25.1
216-
## # available=0.25.2-rc1
217-
## # available=0.25.2
218-
## # available=0.25.3-rc1
219-
## # available=0.25.3
220-
## # available=0.26.0-rc1
221-
## # available=0.26.0
222-
## # available=0.27.0-rc1
223-
## # available=0.27.0-rc2
224-
## # available=0.27.0
225-
## # available=0.28.0-rc1
226-
## # available=0.28.0
180+
version.google.dagger=2.50
181+
182+
version.com.vanniktech..gradle-maven-publish-plugin=0.31.0
227183

228184
version.com.nhaarman.mockitokotlin2..mockito-kotlin=2.2.0
229185

@@ -704,8 +660,8 @@ version.androidx.compose.foundation=1.2.1
704660
## # available=1.7.0-alpha04
705661
## # available=1.7.0-alpha05
706662

707-
## unused
708-
version.androidx.compose.compiler=1.4.8
663+
# For Kotlin 1.9.23, we need a compatible Compose compiler version
664+
version.androidx.compose.compiler=1.5.8
709665

710666
version.androidx.cardview=1.0.0
711667

@@ -759,21 +715,7 @@ version.androidx.activity=1.5.1
759715
## # available=1.9.0-alpha03
760716
## # available=1.9.0-beta01
761717

762-
plugin.io.gitlab.arturbosch.detekt=1.21.0
763-
## # available=1.22.0-RC1
764-
## # available=1.22.0-RC2
765-
## # available=1.22.0-RC3
766-
## # available=1.22.0
767-
## # available=1.23.0-RC1
768-
## # available=1.23.0-RC2
769-
## # available=1.23.0-RC3
770-
## # available=1.23.0
771-
## # available=1.23.1
772-
## # available=1.23.2
773-
## # available=1.23.3
774-
## # available=1.23.4
775-
## # available=1.23.5
776-
## # available=1.23.6
718+
plugin.io.gitlab.arturbosch.detekt=1.23.6
777719

778720
version.anvil=2.4.6
779721
### available=2.4.7

0 commit comments

Comments
 (0)