-
Notifications
You must be signed in to change notification settings - Fork 240
revert: Revert "chore(gRPC): Update a2a.proto to include metadata on GetTaskRequest" #428
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
revert: Revert "chore(gRPC): Update a2a.proto to include metadata on GetTaskRequest" #428
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary of Changes
Hello @a2a-bot, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request, generated automatically, updates the A2A gRPC Python protobuf definitions. The primary change involves removing the metadata
field from the GetTaskRequest
message, reflecting an update in the underlying protocol buffer specification.
Highlights
- Automated Protobuf Update: The pull request automatically updates the generated Python protobuf files, specifically
a2a_pb2.py
anda2a_pb2.pyi
. - Schema Change: GetTaskRequest: The
metadata
field has been removed from theGetTaskRequest
message definition, indicating a change in the underlying protocol specification. - Impact on Python Type Hints: This schema change is reflected in the Python type hint file (
a2a_pb2.pyi
), where the__slots__
and__init__
signature ofGetTaskRequest
have been updated to remove references to themetadata
field.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command>
or @gemini-code-assist <command>
. Below is a summary of the supported commands.
Feature | Command | Description |
---|---|---|
Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/
folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request updates the protobuf-generated files based on a new specification, which includes removing the metadata
field from the GetTaskRequest
message. While the generated files are updated, the supporting code that uses these messages has not been adjusted for this breaking change. This will cause runtime AttributeError
s. I've added a comment pointing to the exact location in src/a2a/utils/proto_utils.py
that needs to be fixed. Please ensure all code using GetTaskRequest
is updated to handle the removal of the metadata
field.
…GetTaskRequest" (a2aproject#428) Commit: a2aproject/A2A@e6b8c65 --------- Co-authored-by: Holt Skinner <[email protected]>
🤖 I have created a release *beep* *boop* --- ## [0.3.3](v0.3.2...v0.3.3) (2025-08-22) ### Features * Update proto conversion utilities ([#424](#424)) ([a3e7e1e](a3e7e1e)) ### Bug Fixes * fixing JSONRPC error mapping ([#414](#414)) ([d2e869f](d2e869f)) * Revert code that enforces uuid structure on context id in tasks ([#429](#429)) ([e3a7207](e3a7207)), closes [#427](#427) ### Performance Improvements * optimize logging performance and modernize string formatting ([#411](#411)) ([3ffae8f](3ffae8f)) ### Reverts * Revert "chore(gRPC): Update a2a.proto to include metadata on GetTaskRequest" ([#428](#428)) ([39c6b43](39c6b43)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Commit: a2aproject/A2A@e6b8c65
Release-As: 0.3.3