Fix lint errors in rest_client

Author: holtskinner

src/a2a/client/__init__.py

@@ -33,9 +33,9 @@
 )
 from a2a.client.middleware import ClientCallContext, ClientCallInterceptor
 from a2a.client.rest_client import (
-    NewRestfulClient,
     RestClient,
     RestTransportClient,
+    new_restful_client,
 )
 
 
@@ -97,9 +97,9 @@ def __init__(self, *args, **kwargs):
     'JsonRpcTransportClient',
     'NewGrpcClient',
     'NewJsonRpcClient',
-    'NewRestfulClient',
     'RestClient',
     'RestTransportClient',
     'create_text_message_object',
     'minimal_agent_card',
+    'new_restful_client',
 ]

src/a2a/client/client_factory.py

@@ -8,7 +8,7 @@
 from a2a.client.grpc_client import NewGrpcClient
 from a2a.client.jsonrpc_client import NewJsonRpcClient
 from a2a.client.middleware import ClientCallInterceptor
-from a2a.client.rest_client import NewRestfulClient
+from a2a.client.rest_client import new_restful_client
 from a2a.types import (
     AgentCapabilities,
     AgentCard,
@@ -61,7 +61,7 @@ def __init__(
         if TransportProtocol.jsonrpc in self._config.supported_transports:
             self._registry[TransportProtocol.jsonrpc] = NewJsonRpcClient
         if TransportProtocol.http_json in self._config.supported_transports:
-            self._registry[TransportProtocol.http_json] = NewRestfulClient
+            self._registry[TransportProtocol.http_json] = new_restful_client
         if TransportProtocol.grpc in self._config.supported_transports:
             self._registry[TransportProtocol.grpc] = NewGrpcClient
 

src/a2a/client/rest_client.py

@@ -589,6 +589,14 @@ def __init__(
     def get_http_args(
         self, context: ClientCallContext
     ) -> dict[str, Any] | None:
+        """Extract HTTP-specific keyword arguments from the client call context.
+
+        Args:
+            context: The client call context.
+
+        Returns:
+            A dictionary of HTTP arguments, or None.
+        """
         return context.state.get('http_kwargs', None) if context else None
 
     async def send_message(
@@ -597,6 +605,18 @@ async def send_message(
         *,
         context: ClientCallContext | None = None,
     ) -> AsyncIterator[Task | Message]:
+        """Send a message to the agent and consumes the response(s).
+
+        This method handles both blocking (non-streaming) and streaming responses
+        based on the client configuration and agent capabilities.
+
+        Args:
+            request: The message to send.
+            context: The client call context.
+
+        Yields:
+            The final message or task result from the agent.
+        """
         config = MessageSendConfiguration(
             accepted_output_modes=self._config.accepted_output_modes,
             blocking=not self._config.polling,
@@ -648,6 +668,15 @@ async def get_task(
         *,
         context: ClientCallContext | None = None,
     ) -> Task:
+        """Retrieve a task from the agent.
+
+        Args:
+            request: Parameters to identify the task.
+            context: The client call context.
+
+        Returns:
+            The requested task.
+        """
         return await self._transport_client.get_task(
             request,
             http_kwargs=self.get_http_args(context),
@@ -660,6 +689,15 @@ async def cancel_task(
         *,
         context: ClientCallContext | None = None,
     ) -> Task:
+        """Cancel an ongoing task on the agent.
+
+        Args:
+            request: Parameters to identify the task to cancel.
+            context: The client call context.
+
+        Returns:
+            The task after the cancellation request.
+        """
         return await self._transport_client.cancel_task(
             request,
             http_kwargs=self.get_http_args(context),
@@ -672,6 +710,15 @@ async def set_task_callback(
         *,
         context: ClientCallContext | None = None,
     ) -> TaskPushNotificationConfig:
+        """Set a push notification callback for a task.
+
+        Args:
+            request: The push notification configuration to set.
+            context: The client call context.
+
+        Returns:
+            The configured task push notification configuration.
+        """
         return await self._transport_client.set_task_callback(
             request,
             http_kwargs=self.get_http_args(context),
@@ -684,6 +731,15 @@ async def get_task_callback(
         *,
         context: ClientCallContext | None = None,
     ) -> TaskPushNotificationConfig:
+        """Retrieve the push notification callback configuration for a task.
+
+        Args:
+            request: Parameters to identify the task and configuration.
+            context: The client call context.
+
+        Returns:
+            The requested task push notification configuration.
+        """
         return await self._transport_client.get_task_callback(
             request,
             http_kwargs=self.get_http_args(context),
@@ -696,6 +752,20 @@ async def resubscribe(
         *,
         context: ClientCallContext | None = None,
     ) -> AsyncIterator[Task | Message]:
+        """Resubscribe to a task's event stream.
+
+        This is only available if both the client and server support streaming.
+
+        Args:
+            request: Parameters to identify the task to resubscribe to.
+            context: The client call context.
+
+        Yields:
+            Task events from the agent.
+
+        Raises:
+            Exception: If streaming is not supported.
+        """
         if not self._config.streaming or not self._card.capabilities.streaming:
             raise Exception(
                 'client and/or server do not support resubscription.'
@@ -713,17 +783,28 @@ async def get_card(
         *,
         context: ClientCallContext | None = None,
     ) -> AgentCard:
+        """Retrieve the agent's card.
+
+        This may involve fetching the public card first if not already available,
+        and then fetching the authenticated extended card if supported and required.
+
+        Args:
+            context: The client call context.
+
+        Returns:
+            The agent's card.
+        """
         return await self._transport_client.get_card(
             http_kwargs=self.get_http_args(context),
             context=context,
         )
 
 
-def NewRestfulClient(
+def new_restful_client(
     card: AgentCard,
     config: ClientConfig,
     consumers: list[Consumer],
     middleware: list[ClientCallInterceptor],
 ) -> Client:
-    """Generator for the `RestClient` implementation."""
+    """Factory function for the `RestClient` implementation."""
     return RestClient(card, config, consumers, middleware)

src/a2a/server/apps/jsonrpc/fastapi_app.py

@@ -87,7 +87,9 @@ def add_routes_to_app(
                 }
             },
         )(self._handle_requests)
-        app.get(agent_card_url)(self._handle_get_agent_card)
+        app.get(agent_card_url)(
+            self._handle_get_agent_card  # ruff noqa: SLF001
+        )
 
         if self.agent_card.supports_authenticated_extended_card:
             app.get(extended_agent_card_url)(