Skip to content

feat(dart_frog): add optional shared parameter to serve function #908

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 16 commits into from
Aug 23, 2023
Merged

feat(dart_frog): add optional shared parameter to serve function #908

merged 16 commits into from
Aug 23, 2023

Conversation

femalemonkeyman
Copy link
Contributor

add an optional shared parameter to the serve function to allow multi-threading of the resulting server

Status

Ready?

Description

add an optional shared parameter to the serve function to allow multi-threading of the resulting server

Type of Change

  • [x ] ✨ New feature (non-breaking change which adds functionality)
  • 🛠️ Bug fix (non-breaking change which fixes an issue)
  • ❌ Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 Code refactor
  • ✅ Build configuration change
  • 📝 Documentation
  • 🗑️ Chore

@femalemonkeyman
Add optional shared parameter to serve function
722c1da 
add an optional shared parameter to the serve function to allow multi-threading of the resulting server
@femalemonkeyman femalemonkeyman changed the title Add optional shared parameter to serve function feat: Add optional shared parameter to serve function Aug 14, 2023
erickzanardo
erickzanardo previously approved these changes Aug 15, 2023
View reviewed changes
alestiago
alestiago reviewed Aug 15, 2023
View reviewed changes
Copy link
Contributor

@alestiago alestiago left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contributing! LGTM, just need to add some tests 💙

@alestiago alestiago added the waiting for response Waiting for follow up label Aug 18, 2023
@alestiago alestiago removed the waiting for response Waiting for follow up label Aug 21, 2023
alestiago
alestiago reviewed Aug 21, 2023
View reviewed changes
@alestiago alestiago added the waiting for response Waiting for follow up label Aug 21, 2023
@alestiago alestiago mentioned this pull request Aug 21, 2023
Merged
7 tasks
@alestiago alestiago self-assigned this Aug 21, 2023
alestiago
alestiago previously approved these changes Aug 22, 2023
View reviewed changes
@alestiago alestiago removed the waiting for response Waiting for follow up label Aug 22, 2023
@alestiago alestiago mentioned this pull request Aug 22, 2023
Closed
7 tasks
alestiago
alestiago reviewed Aug 22, 2023
View reviewed changes
@alestiago alestiago added the feature A new feature or request label Aug 23, 2023
@alestiago alestiago changed the title feat: Add optional shared parameter to serve function feat(dart_frog): add optional shared parameter to serve function Aug 23, 2023
@alestiago alestiago merged commit d7de1eb into dart-frog-dev:main Aug 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wolfenrain wolfenrain wolfenrain approved these changes

@alestiago alestiago alestiago approved these changes

@erickzanardo erickzanardo erickzanardo left review comments

@felangel felangel Awaiting requested review from felangel felangel is a code owner

@renancaraujo renancaraujo Awaiting requested review from renancaraujo renancaraujo is a code owner

Assignees

@femalemonkeyman femalemonkeyman

@alestiago alestiago

Labels
feature A new feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@femalemonkeyman @erickzanardo @wolfenrain @alestiago