Skip to content

Commit 6b1389b

Browse files
AllyTallyNyakoFox
authored andcommitted
Rename size to render_type, turn magic numbers into enum
1 parent b684986 commit 6b1389b

File tree

9 files changed

+108
-91
lines changed

9 files changed

+108
-91
lines changed

desktop_version/src/Ent.cpp

Lines changed: 11 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ void entclass::clear(void)
1313
{
1414
invis = false;
1515
type = EntityType_PLAYER;
16-
size = 0;
16+
render_type = EntityRenderType_SPRITE;
1717
tile = 0;
1818
rule = 0;
1919
state = 0;
@@ -377,22 +377,22 @@ void entclass::settreadmillcolour( int rx, int ry )
377377

378378
void entclass::updatecolour(void)
379379
{
380-
switch (size)
380+
switch (render_type)
381381
{
382-
case 0: // Sprites
383-
case 7: // Teleporter
384-
case 9: // Really Big Sprite! (2x2)
385-
case 10: // 2x1 Sprite
386-
case 13: // Special for epilogue: huge hero!
382+
case EntityRenderType_SPRITE: // Sprites
383+
case EntityRenderType_TELEPORTER: // Teleporter
384+
case EntityRenderType_SPRITE_2x2: // Really Big Sprite! (2x2)
385+
case EntityRenderType_SPRITE_2x1: // 2x1 Sprite
386+
case EntityRenderType_SPRITE_6x: // Special for epilogue: huge hero!
387387
realcol = graphics.getcol(colour);
388388
break;
389-
case 3: // Big chunky pixels!
389+
case EntityRenderType_PARTICLE: // Big chunky pixels!
390390
realcol = graphics.bigchunkygetcol(colour);
391391
break;
392-
case 4: // Small pickups
392+
case EntityRenderType_COIN: // Small pickups
393393
realcol = graphics.huetilegetcol();
394394
break;
395-
case 11: // The fucking elephant
395+
case EntityRenderType_ELEPHANT: // The fucking elephant
396396
if (game.noflashingmode)
397397
{
398398
realcol = graphics.getcol(22);
@@ -402,7 +402,7 @@ void entclass::updatecolour(void)
402402
realcol = graphics.getcol(colour);
403403
}
404404
break;
405-
case 12: // Regular sprites that don't wrap
405+
case EntityRenderType_SPRITE_NO_WRAP: // Regular sprites that don't wrap
406406
// if we're outside the screen, we need to draw indicators
407407
if ((xp < -20 && vx > 0) || (xp > 340 && vx < 0))
408408
{

desktop_version/src/Ent.h

Lines changed: 21 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,6 +33,25 @@ enum EntityType
3333
EntityType_TELEPORTER = 100
3434
};
3535

36+
enum EntityRenderType
37+
{
38+
EntityRenderType_INVALID = -1,
39+
EntityRenderType_SPRITE,
40+
EntityRenderType_TILE,
41+
EntityRenderType_PLATFORM,
42+
EntityRenderType_PARTICLE,
43+
EntityRenderType_COIN,
44+
EntityRenderType_HORIZONTAL_LINE,
45+
EntityRenderType_VERTICAL_LINE,
46+
EntityRenderType_TELEPORTER,
47+
EntityRenderType_PLATFORM_LONG,
48+
EntityRenderType_SPRITE_2x2,
49+
EntityRenderType_SPRITE_2x1,
50+
EntityRenderType_ELEPHANT,
51+
EntityRenderType_SPRITE_NO_WRAP,
52+
EntityRenderType_SPRITE_6x
53+
};
54+
3655
class entclass
3756
{
3857
public:
@@ -55,7 +74,8 @@ class entclass
5574
//Fundamentals
5675
bool invis;
5776
EntityType type;
58-
int size, tile, rule;
77+
EntityRenderType render_type;
78+
int tile, rule;
5979
int state, statedelay;
6080
int behave, animate;
6181
float para;

0 commit comments

Comments
 (0)