[!!!][TASK] Remove workspace 'Freeze Editing'

Workspaces has a feature to mark single workspaces as frozen
to prevent further editing of records. The patch drops this
feature altogether:

While the feature may be theoretically useful, its implementation
is so half-done and sparse that we either have the option to put
a lot of time and effort into it to render it usable, or to remove
it for now in favor of other workspace related features that should
receive love. Asking in the community revealed no single actual
user of the feature, there is only one forge issue exists that
points out a major flaw, and zero work has been put into the
feature since the initial introduction of workspaces.

Some details:
* A frozen workspace can not be published. When a frozen workspace
  means "this has been fully reviewed, do not edit anymore", then
  publishing is the only option that actually *should* be possible.
* Only admins can freeze a workspace. We'd expect owners should be
  able to do this.
* The *only* attached functionality are early checks in DataHandler
  that prevent writing records. They return early and write a log
  entry. There is zero notification whatsoever to the user: There
  are no flash messages during editing that records can't be saved,
  there is no information in the workspace module this workspace
  is frozen, record fields are not readonly, all 'edit pencils'
  are still shown. This turns this feature into a UX disaster.
* A proper "only certain persons can publish a workspace" can be
  realized using custom stages in combination with a list of
  'responsible persons', 'Publish only content in publish stage'
  and 'Restrict publishing to workspace owners'. This is not fully
  documented (which we can change), but ends up in a more flexible
  feature than the half implemented 'Freeze Editing' toggle.

Resolves: #107323
Resolves: #82892
Releases: main
Change-Id: I2327a830a271a2713e92720bd411f3c1d02f07fa
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/90473
Tested-by: Stefan Bürk <[email protected]>
Tested-by: Stefan Froemken <[email protected]>
Tested-by: Christian Kuhn <[email protected]>
Reviewed-by: Stefan Bürk <[email protected]>
Reviewed-by: Stefan Froemken <[email protected]>
Reviewed-by: Christian Kuhn <[email protected]>
Tested-by: core-ci <[email protected]>

Author: lolli42

Configuration/TCA/sys_workspace.php

@@ -76,14 +76,6 @@
                 'default' => 0,
             ],
         ],
-        'freeze' => [
-            'label' => 'LLL:EXT:workspaces/Resources/Private/Language/locallang_db.xlf:sys_workspace.freeze',
-            'config' => [
-                'type' => 'check',
-                'renderType' => 'checkboxToggle',
-                'default' => 0,
-            ],
-        ],
         'live_edit' => [
             'label' => 'LLL:EXT:workspaces/Resources/Private/Language/locallang_db.xlf:sys_workspace.live_edit',
             'config' => [
@@ -240,9 +232,6 @@
         ],
     ],
     'palettes' => [
-        'main' => [
-            'showitem' => 'title,freeze',
-        ],
         'memberlist' => [
             'label' => 'LLL:EXT:workspaces/Resources/Private/Language/locallang_db.xlf:tabs.users',
             'showitem' => 'adminusers,members',
@@ -263,7 +252,7 @@
     'types' => [
         '0' => ['showitem' => '
             --div--;LLL:EXT:core/Resources/Private/Language/Form/locallang_tabs.xlf:general,
-                --palette--;;main,
+                title,
                 stagechg_notification,
                 --palette--;;memberlist,
             --div--;LLL:EXT:workspaces/Resources/Private/Language/locallang_db.xlf:tabs.internal_stages,

Documentation/Administration/CustomWorkspace/Index.rst

@@ -99,8 +99,8 @@ Subsequently you can configure settings for the three predefined stages.
 
 The "Settings dialog" is about the popup window which appears after
 each review process. If the "show dialog" box is not checked, the
-popup will not show notification settings and notifications will 
-be sent according to the predefined settings. 
+popup will not show notification settings and notifications will
+be sent according to the predefined settings.
 When the "changeable preselection" box is checked, the preselected
 list of users to notify can be modified
 on the fly before sending the change notification.
@@ -203,9 +203,6 @@ Other
 The "Other" tab is comprised of various settings affecting
 the behavior of the custom workspace.
 
-The "Freeze editing" flag actually blocks all operations in
-the workspace until it is turned off again.
-
 It is possible to allow editing of non-versionable records
 in the custom workspace. These records will be edited "live",
 i.e. any changes to them performed in the workspace will be

Resources/Private/Language/locallang_db.xlf

@@ -87,9 +87,6 @@
 			<trans-unit id="sys_workspace.unpublish_time">
 				<source>Un-Publish changes on (requires scheduler task)</source>
 			</trans-unit>
-			<trans-unit id="sys_workspace.freeze">
-				<source>Freeze Editing</source>
-			</trans-unit>
 			<trans-unit id="sys_workspace.live_edit">
 				<source>Allow "live" editing of records from tables without versioning</source>
 			</trans-unit>

Tests/Functional/Hook/DataSet/deletingSysWorkspaceDeletesWorkspaceRecords.csv

@@ -1,7 +1,7 @@
 "sys_workspace",,,,,,,,,,,,,,,,,
-,"uid","pid","deleted","title","adminusers","members","db_mountpoints","file_mountpoints","freeze","live_edit","publish_access","custom_stages","stagechg_notification","edit_notification_defaults","edit_allow_notificaton_settings","publish_notification_defaults","publish_allow_notificaton_settings"
-,1,0,0,"Workspace #1",,,,,0,0,0,0,0,0,0,0,0
-,2,0,0,"Workspace #2",,,,,0,0,0,0,0,0,0,0,0
+,"uid","pid","deleted","title","adminusers","members","db_mountpoints","file_mountpoints","live_edit","publish_access","custom_stages","stagechg_notification","edit_notification_defaults","edit_allow_notificaton_settings","publish_notification_defaults","publish_allow_notificaton_settings"
+,1,0,0,"Workspace #1",,,,,0,0,0,0,0,0,0,0
+,2,0,0,"Workspace #2",,,,,0,0,0,0,0,0,0,0
 "pages",,,,,,,,,,,,,,,,,
 ,"uid","pid","sorting","hidden","deleted","l10n_parent","l10n_source","t3ver_wsid","t3ver_state","t3ver_stage","t3ver_oid","title",,,,,
 ,1,0,256,0,0,0,0,0,0,0,0,"FunctionalTest",,,,,

Tests/Functional/Hook/DataSet/deletingSysWorkspaceDeletesWorkspaceRecordsResult.csv

@@ -1,7 +1,7 @@
 "sys_workspace",,,,,,,,,,,,,,,,,
-,"uid","pid","deleted","title","adminusers","members","db_mountpoints","file_mountpoints","freeze","live_edit","publish_access","custom_stages","stagechg_notification","edit_notification_defaults","edit_allow_notificaton_settings","publish_notification_defaults","publish_allow_notificaton_settings"
-,1,0,1,"Workspace #1",,,,,0,0,0,0,0,0,0,0,0
-,2,0,0,"Workspace #2",,,,,0,0,0,0,0,0,0,0,0
+,"uid","pid","deleted","title","adminusers","members","db_mountpoints","file_mountpoints","live_edit","publish_access","custom_stages","stagechg_notification","edit_notification_defaults","edit_allow_notificaton_settings","publish_notification_defaults","publish_allow_notificaton_settings"
+,1,0,1,"Workspace #1",,,,,0,0,0,0,0,0,0,0
+,2,0,0,"Workspace #2",,,,,0,0,0,0,0,0,0,0
 "pages",,,,,,,,,,,,,,,,,
 ,"uid","pid","sorting","hidden","deleted","l10n_parent","l10n_source","t3ver_wsid","t3ver_state","t3ver_stage","t3ver_oid","title",,,,,
 ,1,0,256,0,0,0,0,0,0,0,0,"FunctionalTest",,,,,