Skip to content

Commit 786f22f

Browse files
committed
add more reuse of Database.setTokenAndId
1 parent cc7776e commit 786f22f

File tree

3 files changed

+14
-10
lines changed

3 files changed

+14
-10
lines changed

src/core/executors/LoginUserOperationExecutor.ts

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -223,8 +223,10 @@ export class LoginUserOperationExecutor implements IOperationExecutor {
223223

224224
const pushSubscriptionId = await Database.getPushId();
225225
if (pushSubscriptionId === localId) {
226-
await Database.setPushId(backendSub.id);
227-
await Database.setPushToken(backendSub.token);
226+
await Database.setTokenAndId({
227+
token: backendSub.token,
228+
id: backendSub.id,
229+
});
228230
}
229231

230232
const model =

src/core/executors/SubscriptionOperationExecutor.ts

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -124,8 +124,10 @@ export class SubscriptionOperationExecutor implements IOperationExecutor {
124124

125125
const pushSubscriptionId = await Database.getPushId();
126126
if (pushSubscriptionId === createOperation.subscriptionId) {
127-
await Database.setPushId(backendSubscriptionId);
128-
await Database.setPushToken(subscription?.token);
127+
await Database.setTokenAndId({
128+
token: subscription?.token,
129+
id: backendSubscriptionId,
130+
});
129131
}
130132

131133
return new ExecutionResponse(

src/shared/managers/SubscriptionManager.test.ts

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -51,9 +51,9 @@ describe('SubscriptionManager', () => {
5151
expect(subModels.length).toBe(0);
5252

5353
// mimicing the event helper checkAndTriggerSubscriptionChanged
54-
await OneSignal.database.setPushToken(
55-
rawSubscription.w3cEndpoint?.toString(),
56-
);
54+
await OneSignal.database.setTokenAndId({
55+
token: rawSubscription.w3cEndpoint?.toString(),
56+
});
5757

5858
await subscriptionManager._updatePushSubscriptionModelWithRawSubscription(
5959
rawSubscription,
@@ -164,9 +164,9 @@ describe('SubscriptionManager', () => {
164164
const subscriptionManager = new SubscriptionManager(context, subConfig);
165165
const rawSubscription = getRawSubscription();
166166

167-
await OneSignal.database.setPushToken(
168-
rawSubscription.w3cEndpoint?.toString(),
169-
);
167+
await OneSignal.database.setTokenAndId({
168+
token: rawSubscription.w3cEndpoint?.toString(),
169+
});
170170

171171
const pushModel = await setupSubModelStore({
172172
id: '123',

0 commit comments

Comments
 (0)