Merge pull request #1914 from NullVoxPopuli/upgrade-template-compilation

Upgrade template-compilation

Author: NullVoxPopuli

apps/repl/app/components/limber/layout/orientation.gts

@@ -12,8 +12,6 @@ interface Signature {
   };
 }
 
-const { Boolean } = globalThis;
-
 export const Orientation: TOC<Signature> = <template>
   <ContainerQuery
     @features={{hash isVertical=(aspectRatio max=1.2)}}

apps/repl/app/components/limber/share.gts

@@ -24,8 +24,6 @@ import type RouterService from '@ember/routing/router-service';
 
 const isShowing = cell(false);
 
-const { Boolean } = globalThis;
-
 const not = (x: unknown) => !x;
 
 export const Share = <template>

apps/tutorial/public/docs/1-introduction/6-browser-utilities/answer.gjs

@@ -4,8 +4,6 @@ let data = {
   terrain: "desert",
 };
 
-let { JSON } = globalThis;
-
 localStorage.setItem('localStorage-item', JSON.stringify(data));
 
 let get = (key) => localStorage.getItem(key);

apps/tutorial/public/docs/1-introduction/6-browser-utilities/prompt.gjs

@@ -4,8 +4,6 @@ let data = {
   terrain: "desert",
 };
 
-let { JSON } = globalThis;
-
 localStorage.setItem('localStorage-item', JSON.stringify(data));
 
 let get = (key) => localStorage.getItem(key);

apps/tutorial/public/docs/1-introduction/6-browser-utilities/prose.md

@@ -1,5 +1,3 @@
-All functions available on [`globalThis`][mdn-globalThis] ([window][mdn-Window] in browsers), are available to use in templates.
-
 For example, retrieving data from [`localStorage`][mdn-LocalStorage] may be done like this:
 
 ```hbs
@@ -33,7 +31,6 @@ function formatFromStorage(key) {
 
 Since templates are the _source of truth_ for what is visible to users, it's useful to make them as readable as possible. An extra advantage here is that the extracted functions can more easily be unit tested.
 
-[mdn-globalThis]: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/globalThis
 [mdn-Window]: https://developer.mozilla.org/en-US/docs/Web/API/Window
 [mdn-LocalStorage]: https://developer.mozilla.org/en-US/docs/Web/API/Window/localStorage
 [mdn-json-stringify]: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/JSON/stringify

apps/tutorial/public/docs/12-loading-patterns/1-keeping-latest/answer.gjs

@@ -6,7 +6,6 @@ import { use, resource } from 'ember-resources';
 import { RemoteData, remoteData } from 'reactiveweb/remote-data';
 import { keepLatest } from 'reactiveweb/keep-latest';
 
-const { JSON } = globalThis;
 const isEmpty = (x) => !x || x?.length === 0;
 const urlFor = (id) => `https://swapi.tech/api/people/${id}`;
 

apps/tutorial/public/docs/12-loading-patterns/1-keeping-latest/prompt.gjs

@@ -6,7 +6,6 @@ import { use, resource } from 'ember-resources';
 import { RemoteData, remoteData } from 'reactiveweb/remote-data';
 import { keepLatest } from 'reactiveweb/keep-latest';
 
-const { JSON } = globalThis;
 const isEmpty = (x) => !x || x?.length === 0;
 const urlFor = (id) => `https://swapi.tech/api/people/${id}`;
 

apps/tutorial/public/docs/8-form-data-controlled/7-contenteditable/answer.gjs

@@ -4,7 +4,6 @@ import { on } from '@ember/modifier';
 import { fn } from '@ember/helper';
 import { modifier } from 'ember-modifier';
 
-let { document } = globalThis;
 const bold = () => document.execCommand("bold", false, null);
 const italic = () => document.execCommand("italic", false, null);
 const underline = () => document.execCommand("underline", false, null);

apps/tutorial/public/docs/8-form-data-controlled/7-contenteditable/prompt.gjs

@@ -4,7 +4,6 @@ import { on } from '@ember/modifier';
 import { fn } from '@ember/helper';
 import { modifier } from 'ember-modifier';
 
-let { document } = globalThis;
 const bold = () => document.execCommand("bold", false, null);
 const italic = () => document.execCommand("italic", false, null);
 const underline = () => document.execCommand("underline", false, null);

packages/app-support/limber-ui/addon/package.json

@@ -72,7 +72,7 @@
     "@nullvoxpopuli/eslint-configs": "^5.0.0",
     "@rollup/plugin-babel": "^6.0.4",
     "@tsconfig/ember": "^3.0.9",
-    "babel-plugin-ember-template-compilation": "^2.3.0",
+    "babel-plugin-ember-template-compilation": "^2.4.0",
     "concurrently": "^9.1.2",
     "ember-async-data": "1.0.3",
     "ember-cli-htmlbars": "^6.3.0",