Update DeviceGetconfComputeGpuAttestationReport to take struct as input

This is a BREAKING CHANGE, but one that is necessary, because the API is
unusable in its current form. In the C API, the input struct us used to
pass _both_ input _and_ output. In our original implementation we didn't
take this struct as input, so there was no way to get this input passed
into the function. The API has now been updated to correct this.

One option could have been to just add the single input field as an
input to the API call on its own, but this is not scalable in cases
where one my add more input fields to the struct in the future.

In the end, (even though this goes against our other wrapper API calls),
we decided it was best to just pass the whole struct and assume its
usage as both input and output just like the C API.

We plan to revisit how to more comprehensively accommodate APIS such as
this in the future.

Signed-off-by: Kevin Klues <[email protected]>

Author: klueska

pkg/nvml/device.go

@@ -2971,14 +2971,12 @@ func (device nvmlDevice) GetConfComputeGpuCertificate() (ConfComputeGpuCertifica
 }
 
 // nvml.DeviceGetConfComputeGpuAttestationReport()
-func (l *library) DeviceGetConfComputeGpuAttestationReport(device Device) (ConfComputeGpuAttestationReport, Return) {
-	return device.GetConfComputeGpuAttestationReport()
+func (l *library) DeviceGetConfComputeGpuAttestationReport(device Device, gpuAtstReport *ConfComputeGpuAttestationReport) Return {
+	return device.GetConfComputeGpuAttestationReport(gpuAtstReport)
 }
 
-func (device nvmlDevice) GetConfComputeGpuAttestationReport() (ConfComputeGpuAttestationReport, Return) {
-	var gpuAtstReport ConfComputeGpuAttestationReport
-	ret := nvmlDeviceGetConfComputeGpuAttestationReport(device, &gpuAtstReport)
-	return gpuAtstReport, ret
+func (device nvmlDevice) GetConfComputeGpuAttestationReport(gpuAtstReport *ConfComputeGpuAttestationReport) Return {
+	return nvmlDeviceGetConfComputeGpuAttestationReport(device, gpuAtstReport)
 }
 
 // nvml.DeviceSetConfComputeUnprotectedMemSize()

pkg/nvml/mock/device.go

@@ -437,7 +437,7 @@ type Interface interface {
 	DeviceGetComputeInstanceId(Device) (int, Return)
 	DeviceGetComputeMode(Device) (ComputeMode, Return)
 	DeviceGetComputeRunningProcesses(Device) ([]ProcessInfo, Return)
-	DeviceGetConfComputeGpuAttestationReport(Device) (ConfComputeGpuAttestationReport, Return)
+	DeviceGetConfComputeGpuAttestationReport(Device, *ConfComputeGpuAttestationReport) Return
 	DeviceGetConfComputeGpuCertificate(Device) (ConfComputeGpuCertificate, Return)
 	DeviceGetConfComputeMemSizeInfo(Device) (ConfComputeMemSizeInfo, Return)
 	DeviceGetConfComputeProtectedMemoryUsage(Device) (Memory, Return)
@@ -814,7 +814,7 @@ type Device interface {
 	GetComputeInstanceId() (int, Return)
 	GetComputeMode() (ComputeMode, Return)
 	GetComputeRunningProcesses() ([]ProcessInfo, Return)
-	GetConfComputeGpuAttestationReport() (ConfComputeGpuAttestationReport, Return)
+	GetConfComputeGpuAttestationReport(*ConfComputeGpuAttestationReport) Return
 	GetConfComputeGpuCertificate() (ConfComputeGpuCertificate, Return)
 	GetConfComputeMemSizeInfo() (ConfComputeMemSizeInfo, Return)
 	GetConfComputeProtectedMemoryUsage() (Memory, Return)