Skip to content

Commit 4c70b0a

Browse files
Apply suggestions from code review
Co-authored-by: Max Horn <[email protected]>
1 parent ca3bea1 commit 4c70b0a

File tree

3 files changed

+4
-4
lines changed

3 files changed

+4
-4
lines changed

base/Base.jl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -498,7 +498,7 @@ include(mapexpr::Function, mod::Module, _path::AbstractString) = _include(mapexp
498498
Core.println("JuliaSyntax/src/JuliaSyntax.jl")
499499
include(@__MODULE__, "JuliaSyntax/src/JuliaSyntax.jl")
500500

501-
# Finish up by inserting lazy libraries for the JLLS that must be loaded during bootstrap
501+
# Finish up by inserting lazy libraries for the JLLs that must be loaded during bootstrap
502502
include(@__MODULE__, "base_jll_insertion.jl")
503503

504504
end_base_include = time_ns()

base/base_jll_adapters.jl

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
# This file serves as a way to provide access to libraries that Base needs
22
# that are usually included as artifacts. We can't use Artifacts this early
3-
# becuase we haven't bootstrapped far enough, so this file contains "Base"
3+
# because we haven't bootstrapped far enough, so this file contains "Base"
44
# JLLs that are manually adapted to load things from hardcoded paths so that
55
# we can bootstrap, but once GMP_jll, MPFR_jll, etc... are loaded, we replace
66
# the definitions here with the `LazyLibrary` objects defined there, as they
@@ -42,7 +42,7 @@ Base.cconvert(::Type{Cstring}, llp::LazyLibraryPath) = Base.cconvert(Cstring, st
4242
Base.print(io::IO, llp::LazyLibraryPath) = print(io, string(llp))
4343

4444
# Helper to get `Sys.BINDIR` at runtime
45-
struct SysBindirGetter; end
45+
struct SysBindirGetter end
4646
Base.string(::SysBindirGetter) = string(ccall(:jl_get_julia_bindir, Any, ())::String, early_pathsep, "..")
4747

4848
"""

base/base_jll_insertion.jl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
# Insert LazyLibrary for `libpcre`, although at this time this gets lazily
1+
# Insert LazyLibrary for `libpcre`, although at this time this gets lazily loaded
22
# on startup because `include()` calls `isdirpath()` which has a regex in it.
33
using Base.JLLAdapters: libpcre2_8, libpcre2_8_name
44
using Base.Libc.Libdl: BundledLazyLibraryPath, LazyLibrary

0 commit comments

Comments
 (0)