Wait for other threads to finish compiling before exiting (#51213)

gbaraldi · KristofferC · commit 405e1a4124cd · 2023-11-13T13:23:28.000+01:00
This avoids a crashes where we run the destructors because C++ is fun and runs destructors before thread exit. (cherry picked from commit 3d88550)
diff --git a/src/codegen.cpp b/src/codegen.cpp
@@ -9294,6 +9294,8 @@ extern "C" JL_DLLEXPORT_CODEGEN void jl_teardown_codegen_impl() JL_NOTSAFEPOINT
     if (jl_ExecutionEngine)
         jl_ExecutionEngine->printTimers();
     PrintStatistics();
+    JL_LOCK(&jl_codegen_lock); // TODO: If this lock gets removed reconsider
+                                    // LLVM global state/destructors (maybe a rwlock)
 }
 
 // the rest of this file are convenience functions

Original file line number	Diff line number	Diff line change
`@@ -9294,6 +9294,8 @@ extern "C" JL_DLLEXPORT_CODEGEN void jl_teardown_codegen_impl() JL_NOTSAFEPOINT`
`9294`	`9294`	`if (jl_ExecutionEngine)`
`9295`	`9295`	`jl_ExecutionEngine->printTimers();`
`9296`	`9296`	`PrintStatistics();`
	`9297`	`+ JL_LOCK(&jl_codegen_lock); // TODO: If this lock gets removed reconsider`
	`9298`	`+ // LLVM global state/destructors (maybe a rwlock)`
`9297`	`9299`	`}`
`9298`	`9300`
`9299`	`9301`	`// the rest of this file are convenience functions`