more refactoring and removing todos

Author: xav-db

helix-db/src/helix_engine/macros.rs

@@ -178,9 +178,6 @@ pub mod macros {
     #[macro_export]
     macro_rules! traversal_remapping {
         ($remapping_vals:expr, $var_name:expr, $should_spread:expr, $new_name:expr => $traversal:expr) => {{
-            // TODO: ref?
-            // Apply remappings to the nested traversal result
-
             let nested_return_value = ReturnValue::from_traversal_value_array_with_mixin(
                 $traversal,
                 $remapping_vals.borrow_mut(),

helix-db/src/helix_engine/traversal_core/ops/source/n_from_index.rs

@@ -81,7 +81,6 @@ impl<'a, I: Iterator<Item = Result<TraversalValue, GraphError>>, K: Into<Value>
             .storage
             .secondary_indices
             .get(index)
-            // TODO: this
             .ok_or(GraphError::New(format!(
                 "Secondary Index {index} not found"
             )))

helix-db/src/helix_engine/traversal_core/ops/vectors/insert.rs

@@ -8,7 +8,6 @@ use crate::{
     },
     protocol::value::Value,
 };
-use std::sync::Arc;
 
 pub struct InsertVIterator {
     inner: std::iter::Once<Result<TraversalValue, GraphError>>,
@@ -31,14 +30,6 @@ pub trait InsertVAdapter<'a, 'b>: Iterator<Item = Result<TraversalValue, GraphEr
     ) -> RwTraversalIterator<'a, 'b, impl Iterator<Item = Result<TraversalValue, GraphError>>>
     where
         F: Fn(&HVector, &RoTxn) -> bool;
-
-    fn insert_vs<F>(
-        self,
-        queries: &[Vec<f64>],
-        fields: Option<Vec<(String, Value)>>,
-    ) -> RwTraversalIterator<'a, 'b, impl Iterator<Item = Result<TraversalValue, GraphError>>>
-    where
-        F: Fn(&HVector, &RoTxn) -> bool;
 }
 
 impl<'a, 'b, I: Iterator<Item = Result<TraversalValue, GraphError>>> InsertVAdapter<'a, 'b>
@@ -77,32 +68,4 @@ impl<'a, 'b, I: Iterator<Item = Result<TraversalValue, GraphError>>> InsertVAdap
             txn: self.txn,
         }
     }
-
-    fn insert_vs<F>(
-        self,
-        queries: &[Vec<f64>],
-        fields: Option<Vec<(String, Value)>>,
-    ) -> RwTraversalIterator<'a, 'b, impl Iterator<Item = Result<TraversalValue, GraphError>>>
-    where
-        F: Fn(&HVector, &RoTxn) -> bool,
-    {
-        let txn = self.txn;
-        let storage = Arc::clone(&self.storage);
-        let iter = queries
-            .iter()
-            .map(|vec| {
-                let vector = storage.vectors.insert::<F>(txn, vec, fields.clone()); // TODO: remove clone
-                match vector {
-                    Ok(vector) => Ok(TraversalValue::Vector(vector)),
-                    Err(e) => Err(GraphError::from(e)),
-                }
-            })
-            .collect::<Vec<_>>();
-
-        RwTraversalIterator {
-            inner: iter.into_iter(),
-            storage: self.storage,
-            txn,
-        }
-    }
 }

helix-db/src/helix_engine/vector_core/vector_core.rs

@@ -106,8 +106,6 @@ impl VectorCore {
 
     #[inline]
     fn get_new_level(&self) -> usize {
-        // TODO: look at using the XOR shift algorithm for random number generation
-        // Should instead using an atomic mutable seed and the XOR shift algorithm
         let mut rng = rand::rng();
         let r: f64 = rng.random::<f64>();
         (-r.ln() * self.config.m_l).floor() as usize
@@ -175,7 +173,6 @@ impl VectorCore {
         for result in iter {
             let (key, _) = result?;
 
-            // TODO: fix here because not working at all
             let mut arr = [0u8; 16];
             let len = std::cmp::min(key.len(), 16);
             arr[..len].copy_from_slice(&key[prefix_len..(prefix_len + len)]);
@@ -188,20 +185,13 @@ impl VectorCore {
             let vector = self.get_vector(txn, neighbor_id, level, false)?;
 
             let passes_filters = match filter {
-                // TODO: look at implementing a macro that actually just runs each function rather than iterating through
                 Some(filter_slice) => filter_slice.iter().all(|f| f(&vector, txn)),
                 None => true,
             };
 
             if passes_filters {
                 neighbors.push(vector);
             }
-
-            //if let Ok(vector) = self.get_vector(txn, neighbor_id, level, true) {
-            //    if filter.is_none() || filter.unwrap().iter().all(|f| f(&vector, txn)) {
-            //        neighbors.push(vector);
-            //    }
-            //}
         }
         neighbors.shrink_to_fit();
 

helix-db/src/helix_gateway/embedding_providers/embedding_providers.rs

@@ -5,9 +5,6 @@ use sonic_rs::{JsonContainerTrait, json};
 use std::env;
 use url::Url;
 
-// TODO: add support for rust native embedding model libs as well so it runs fully built in
-//      in case we have a gpu or something on the server we're running it on
-
 /// Trait for embedding models to fetch text embeddings.
 #[allow(async_fn_in_trait)]
 pub trait EmbeddingModel {

helix-db/src/helix_gateway/worker_pool/mod.rs

@@ -33,8 +33,8 @@ impl WorkerPool {
             "Expected number of threads in thread pool to be more than 0, got {size}"
         );
 
-        let (req_tx, req_rx) = flume::bounded::<ReqMsg>(1000); // TODO: make this configurable
-        let (cont_tx, cont_rx) = flume::bounded::<ContMsg>(1000); // TODO: make this configurable
+        let (req_tx, req_rx) = flume::bounded::<ReqMsg>(1000); 
+        let (cont_tx, cont_rx) = flume::bounded::<ContMsg>(1000); 
 
         let workers = (0..size)
             .map(|_| {

helix-db/src/helixc/analyzer/methods/infer_expr_type.rs

@@ -558,7 +558,6 @@ pub(crate) fn infer_expr_type<'a>(
                     from,
                     label,
                     properties,
-                    // secondary_indices: None, // TODO: Add secondary indices by checking against labeled `INDEX` fields in schema
                 };
                 let stmt = GeneratedStatement::Traversal(GeneratedTraversal {
                     source_step: Separator::Period(SourceStep::AddE(add_e)),

helix-db/src/helixc/analyzer/methods/traversal_validation.rs

@@ -287,7 +287,8 @@ pub(crate) fn validate_traversal<'a>(
         // anonymous will be the traversal type rather than the start type
         StartNode::Anonymous => {
             let parent = parent_ty.unwrap();
-            gen_traversal.traversal_type = TraversalType::FromVar(GenRef::Std(DEFAULT_VAR_NAME.to_string())); 
+            gen_traversal.traversal_type =
+                TraversalType::FromVar(GenRef::Std(DEFAULT_VAR_NAME.to_string()));
             gen_traversal.source_step = Separator::Empty(SourceStep::Anonymous);
             parent
         }
@@ -531,16 +532,6 @@ pub(crate) fn validate_traversal<'a>(
             }
 
             StepType::Object(obj) => {
-                // TODO: Fix issue with step count being incorrect (i think its counting each field as a step)
-                // if i != number_of_steps {
-                //     println!("{} {}", i, number_of_steps);
-                //     push_query_err(ctx,
-                //         original_query,
-                //         obj.loc.clone(),
-                //         "object is only valid as the last step in a traversal".to_string(),
-                //         "move the object to the end of the traversal",
-                //     );
-                // }
                 validate_object(
                     ctx,
                     &cur_ty,